From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3462236C; Sat, 4 Jan 2025 17:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736011790; cv=none; b=p51LgSdLCMjJXyWUYS1owLo6SXZqNFrYSraOiSVQyaWrXnXFkVZ1oKLF0pYJzaEfMcB1SgSm1LfvstNtJaFqG8jyJWWpqLni2PKaolNgb9b8d+lSSz5fQzbko16H1bOjO5PUkXtL0oQLM4wUY/1OnpLnU9QowEnBHZuUD3yRLnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736011790; c=relaxed/simple; bh=2LQp/E4jBX/LFz6Xj6POQuDcTwz4Ws1x6LtC6rZ8Tqo=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Br4p/QScuQRXmof+WHxGxmmr+GJMFMf8OAVa2n0MbbUBSpsxkrFz79M3xay+ivxZz4dafE29A7ussbuxetnWJNMnM0zDDjNgyIwVUavF9yI49XrYU4Tg2aQUHUsQxvsiv2HtZs0EEpIgALc+LOTT9hkV/nIfduQvimEn+4EKNF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z7O7E18T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z7O7E18T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63F72C4CED1; Sat, 4 Jan 2025 17:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736011789; bh=2LQp/E4jBX/LFz6Xj6POQuDcTwz4Ws1x6LtC6rZ8Tqo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Z7O7E18T53GJFk1ai1NdXe9PiudmH/pTEF/eURAh+Xs99+23iX7AXuH6MXubykJdT mfrdfrkNz3Mpdo0zdcshPk8c2pngkFBCL5rlR1IlrMdcVq0FdUU5PTUMN3epJqKJlW k9jvhMkyXtjPuwhfhVYNTkT0xs5YR/GPhmL/YHNiz1sb24jERRlaEkjZ6PIMl63nhf 6/Tsv9js7NF3j26tP8Mc0lbyZz97W0K2YqL7vkDXTftkN7kWus+hNpBvllAO0LwcA8 +3gah6TH33SF7V5Ph1gAbVLNlHh6AZOTYAkzd/bXK9FjyT5/cJ3Gsb0xpF5P6rO/VX 3ekRoDmUHkYtg== Message-ID: <64d14e8f-a1d5-4e04-afa7-c129cee29dc2@kernel.org> Date: Sat, 4 Jan 2025 19:29:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth To: Andreas Kemnade , Rob Herring , Conor Dooley , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Aaro Koskinen , Kevin Hilman , devicetree@vger.kernel.org, Krzysztof Kozlowski , Tony Lindgren References: <20241229230125.85787-1-andreas@kemnade.info> <20241229230125.85787-3-andreas@kemnade.info> Content-Language: en-US From: Roger Quadros In-Reply-To: <20241229230125.85787-3-andreas@kemnade.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello Andreas, On 30/12/2024 01:01, Andreas Kemnade wrote: > Bluetooth is available on the other Panda board versions, too, so move > stuff to common and specify the needed clock properly. > > Signed-off-by: Andreas Kemnade > --- > .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++-- > arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ------------------- > 2 files changed, 28 insertions(+), 34 deletions(-) > > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > index c860b590142a..c048ab9af053 100644 > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi > @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */ > wl12xx_gpio: wl12xx-gpio-pins { > pinctrl-single,pins = < > OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */ > - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */ > OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ This one is FM_EN and has nothing to do with WLAN. > - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */ > >; > }; > > @@ -393,6 +391,22 @@ button_pins: button-pins { > OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */ > >; > }; > + > + bt_pins: bt-pins { > + pinctrl-single,pins = < > + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */ > + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */ Could we please use comment style . - Function OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */ OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */ > + >; > + }; > + > + uart2_pins: uart2-pins { > + pinctrl-single,pins = < > + OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts - HCI */ > + OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts */ > + OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx */ > + OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx */ Need to fix comment style to . - Function > + >; > + }; > }; > > &omap4_pmx_wkup { > @@ -531,8 +545,20 @@ &twl_usb_comparator { > }; > > &uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart2_pins>; > + Unnecessary new line. > interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH > &omap4_pmx_core OMAP4_UART2_RX>; > + Here too? > + bluetooth { > + compatible = "ti,wl1271-st"; > + pinctrl-names = "default"; > + pinctrl-0 = <&bt_pins>; > + enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */ > + clocks = <&twl 0>; > + clock-names = "ext_clock"; > + }; > }; > > &uart3 { > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts > index fe7b156d10ed..a933fe560834 100644 > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts > @@ -49,22 +49,6 @@ button_pins: button-pins { > OMAP4_IOPAD(0x0fc, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_113 */ > >; > }; > - > - bt_pins: bt-pins { > - pinctrl-single,pins = < > - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */ > - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */ > - >; > - }; > - > - uart2_pins: uart2-pins { > - pinctrl-single,pins = < > - OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts.uart2_cts - HCI */ > - OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts.uart2_rts */ > - OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx.uart2_rx */ > - OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx.uart2_tx */ > - >; > - }; > }; > > &led_wkgpio_pins { > @@ -96,19 +80,3 @@ buttonS2 { > &gpio1_target { > ti,no-reset-on-init; > }; > - > -&wl12xx_gpio { > - pinctrl-single,pins = < > - OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */ > - OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */ > - >; > -}; > - > -&uart2 { > - pinctrl-names = "default"; > - pinctrl-0 = <&uart2_pins &bt_pins>; > - bluetooth: tiwi { > - compatible = "ti,wl1271-st"; > - enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */ > - }; > -}; -- cheers, -roger