From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9F1C30633 for ; Thu, 17 Aug 2023 15:06:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352710AbjHQPFg (ORCPT ); Thu, 17 Aug 2023 11:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352823AbjHQPFZ (ORCPT ); Thu, 17 Aug 2023 11:05:25 -0400 Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 366952D78 for ; Thu, 17 Aug 2023 08:05:21 -0700 (PDT) Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1bff2d2c141so4598707fac.1 for ; Thu, 17 Aug 2023 08:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692284720; x=1692889520; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=deyjZLeLJlZBKubG6uZiC2GX/sQ0rpTBXelPhs8NNsk=; b=WCX1YMDceHg90Q9VDL/ZTou3tFbnUMBONWxIBO4pyfKoUEzF4PFwte1LISKChgB5/t eabHyn6JSK54nDzUHMEFq3vwJ+5mzh2WqJQsX1nmgrhyNuchtyIsqg6CFqpdzl2Xjab7 fyRnsMz7e+Flq8+B9TsjgpzoUP/WtKSCB5xkCjMBlU5oOtYbume0WIjp0QdnijO8lC/n C8jHwEsnFVubjaB0QQzJuDTu6DWTLnFkKZT5mP2IEnhw7iQ0PXXKcbl1QlUjjbZNBpvN 8rewbAUoxhgwtLytYpU4EWqdujeb5L/Fz+SroZRyy/zK7klRLaMcxV3xrpgx1rur98nF IqBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692284720; x=1692889520; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=deyjZLeLJlZBKubG6uZiC2GX/sQ0rpTBXelPhs8NNsk=; b=diAoECiOxsXMJYJfL+pyen0xh5sVE2Hyhu7zHSiTxw4U7GmDi6XhkJu31dpZl97iq3 FA0lPHYEeVbdUcLuL6CmuN8L+g/S1jo/WVttl6D7x6FnCXnSfe+oCRTdYhT5uob2Swta dwQBLjQQUHJdZEgWkzV5TvGeMqqPJjQED8w5IOphnGyG+xCdcCo+8FqoW7W51/S4SmCy +l6Jr51ncsrXcLuABuN665Uy0wqFERN5oSUvebqte3WrL/276KCWaH00ZN1tayW1nJYs unBe+XFIHHMe2P/ehfhjlUi5hm0ZVZzhQ+WWd3J37G7bfB384oAaOLT8F6Puljxd/e6g 9FuQ== X-Gm-Message-State: AOJu0YyrmrY1ECMc96Vn7IfQ0Z26BpVAqot7MMb40NJltwMeYp+azGFV JaEVNQgSZn2V699xvMvhYis= X-Google-Smtp-Source: AGHT+IGs5rYhDcqho7rv8u5Z89EZt3O4Lm4CO/AsjRZBf+TzcBRtA0xL7NBRP7/I9upLKdtp+TH3vw== X-Received: by 2002:a05:6871:212:b0:1be:e6d6:15c4 with SMTP id t18-20020a056871021200b001bee6d615c4mr5563102oad.9.1692284720360; Thu, 17 Aug 2023 08:05:20 -0700 (PDT) Received: from neuromancer. ([75.28.21.198]) by smtp.gmail.com with ESMTPSA id e4-20020a9d63c4000000b006b9d21100d0sm7070234otl.64.2023.08.17.08.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 08:05:19 -0700 (PDT) Message-ID: <64de372f.9d0a0220.f75e0.abb0@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 17 Aug 2023 10:05:18 -0500 From: Chris Morgan To: Rob Herring Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, neil.armstrong@linaro.org, Chris Morgan Subject: Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support References: <20230809153941.1172-1-macroalpha82@gmail.com> <20230809153941.1172-2-macroalpha82@gmail.com> <20230810232409.GA1548096-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Aug 11, 2023 at 09:41:50AM -0500, Chris Morgan wrote: > On Thu, Aug 10, 2023 at 05:24:09PM -0600, Rob Herring wrote: > > On Wed, Aug 09, 2023 at 10:39:40AM -0500, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Document the Anbernic RG351V panel, which appears to be identical to > > > the panel used in their 353 series except for in inclusion of an > > > additional DSI format flag. > > > > > > Signed-off-by: Chris Morgan > > > --- > > > .../display/panel/newvision,nv3051d.yaml | 18 ++++++++++-------- > > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > > index 116c1b6030a2..576f3640cb33 100644 > > > --- a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > > +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > > @@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > > > title: NewVision NV3051D based LCD panel > > > > > > description: | > > > - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, > > > - this driver only supports the 640x480 panels found in the Anbernic RG353 > > > - based devices. > > > + The NewVision NV3051D is a driver chip used to drive DSI panels. > > > > > > maintainers: > > > - Chris Morgan > > > @@ -19,11 +17,15 @@ allOf: > > > > > > properties: > > > compatible: > > > - items: > > > - - enum: > > > - - anbernic,rg353p-panel > > > - - anbernic,rg353v-panel > > > - - const: newvision,nv3051d > > > + oneOf: > > > + - items: > > > + - enum: > > > + - anbernic,rg353p-panel > > > + - anbernic,rg353v-panel > > > + - const: newvision,nv3051d > > > + > > > + - items: > > > + - const: anbernic,rg351v-panel > > > > I don't understand. Is this panel not based on newvision,nv3051d? If > > not, then it probably should be a different binding. Lot's of panel > > bindings have similar properties. > > It appears to be the same panel (or extremely similar, honestly I don't > know because there are no external markings on it). However, this > specific implementation seems to require MIPI_DSI_CLOCK_NON_CONTINUOUS, > not using it prevents the panel from working. As for the existing panel > MIPI_DSI_CLOCK_NON_CONTINUOUS stops it from working. The different > binding essentially determines whether or not that flag is present, but > otherwise everything else is identical. > > Chris If this is not correct I could also change it so instead there is a property that toggles the MIPI_DSI_CLOCK_NON_CONTINUOUS flag, something like "newvision,clk_non_continuous". Again aside from this flag the panel itself is identical to the one already supported by this driver. Thank you, Chris > > > > > Rob