From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m8240.xmail.ntesmail.com (mail-m8240.xmail.ntesmail.com [156.224.82.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF9418E1F; Thu, 6 Nov 2025 03:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.224.82.40 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762400559; cv=none; b=BwSmNQE5Ocu9GWhLK/InjFHjGrz5oA35aedL7eGQkD9XIhHdP0osB8AnX+6ZNQil+rOfN2Cdo5txc1RToLHXiOElh2I8dS4BekUAARd5AexC5gJNEkzFjZM3ZWH2JEMzOdXgzfNqBhb53kFo2LdFueJ+JUIPvLOXT7xjAeQ6avc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762400559; c=relaxed/simple; bh=TzX8m58SmqbwimRAq1EhErxeZeCXyR9XP1KXrbaHUCA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o8QjsIFxT2AxwjFXc+vjuUem3tm0rC+SBPj7tSmLHeX27yewQrFqH7ubqIUFvhv/M89ShaOX85rGSrsRbbjE9sQZZWhkCvx2AUHUAiQt5anaEGvdMkHJnM6Q95kWCbZPrdyzA30qi7eK/37RiaDDiMka4/Zu26arG7XnsQg+ZZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=evRfUVzE; arc=none smtp.client-ip=156.224.82.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="evRfUVzE" Received: from [172.16.12.149] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2893b798a; Thu, 6 Nov 2025 11:06:56 +0800 (GMT+08:00) Message-ID: <64de56d4-43e8-4e77-a171-0bd0855ad816@rock-chips.com> Date: Thu, 6 Nov 2025 11:06:54 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 03/10] drm/bridge: Implement generic USB Type-C DP HPD bridge To: Dmitry Baryshkov , Chaoyi Chen Cc: Heikki Krogerus , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20251029071435.88-1-kernel@airkyi.com> <20251029071435.88-4-kernel@airkyi.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9a5721af0c03abkunm89fae464e7fb72 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUtKHlZKSk1MSE5OS0kfTkpWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpPSE xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=evRfUVzE9gnJAOXo0XuZFWXMj+MLkXfh5miIhw12ck4N1iYs5TbQdrxU9sXAhiqRhN95j9bofAlR+87xDufP/ZBmz83i5dVRqQ8YiIiWE3TJThOgujLTjEgg/nXx4gfI/QUtvi+Nqf0kpUsoxBrB6H+DOC0XV+9rUTNW2AupTjQ=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=uxhO0QLYdKtAxkfwSVZCwZIlmY3EqbMoelKvCYvQETM=; h=date:mime-version:subject:message-id:from; On 11/3/2025 12:00 PM, Dmitry Baryshkov wrote: > On Wed, Oct 29, 2025 at 03:14:28PM +0800, Chaoyi Chen wrote: >> From: Chaoyi Chen >> >> Several USB-C controller drivers have already implemented the DP HPD >> bridge function provided by aux-hpd-bridge.c, but there are still >> some USB-C controller driver that have not yet implemented it. >> >> This patch implements a generic DP HPD bridge based on aux-hpd-bridge.c, >> so that other USB-C controller drivers don't need to implement it again. > This doesn't describe the problem that you are trying to solve. > >> Signed-off-by: Chaoyi Chen >> --- >> >> Changes in v8: >> - Merge generic DP HPD bridge into one module. >> >> drivers/gpu/drm/bridge/Kconfig | 5 +- >> drivers/gpu/drm/bridge/Makefile | 8 +++- >> drivers/gpu/drm/bridge/aux-hpd-bridge.c | 23 ++++++++- >> drivers/gpu/drm/bridge/aux-hpd-bridge.h | 13 +++++ >> .../gpu/drm/bridge/aux-hpd-typec-dp-bridge.c | 47 +++++++++++++++++++ >> 5 files changed, 93 insertions(+), 3 deletions(-) >> create mode 100644 drivers/gpu/drm/bridge/aux-hpd-bridge.h >> create mode 100644 drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c >> >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >> index a250afd8d662..17257b223a28 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -23,13 +23,16 @@ config DRM_AUX_BRIDGE >> build bridges chain. >> >> config DRM_AUX_HPD_BRIDGE >> - tristate >> + tristate "AUX HPD bridge support" > Why? No, this is supposed to be selected by other drivers. Users don't > know an wouldn't know what is this. > Sorry, I might have misunderstood you point. In v7, I added a new DRM_AUX_TYPEC_DP_HPD_BRIDGE module to select DRM_AUX_HPD_BRIDGE. This seems to fit the "selected by other drivers" scenario, but I think you might not want to expose any information to the users. And the other one is what Heikki said: +if DRM_AUX_HPD_BRIDGE + +config DRM_AUX_HPD_TYPEC_BRIDGE + tristate + depends on TYPEC || !TYPEC + default TYPEC + +endif /* DRM_AUX_HPD_BRIDGE */ + menu "Display Interface Bridges" depends on DRM && DRM_BRIDGE If I understand correctly, in this scenario we need to select DRM_AUX_HPD_BRIDGE in the DP driver. When Type-C is available, DRM_AUX_HPD_TYPEC_BRIDGE will be selected automatically. Is the method mentioned by Heikki what you want? Thank you. -- Best, Chaoyi