From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l+tWKgXG" Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 283D79C for ; Thu, 14 Dec 2023 06:09:43 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a1c7b20f895so944728966b.2 for ; Thu, 14 Dec 2023 06:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702562981; x=1703167781; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/3RQuNkLRKG8bKgPIldu8Ku3xY7yfi4XKy/b0IC08t8=; b=l+tWKgXGoq20hunhC7pGAIw0Ef+qDD41fvB2uNYNTNISgK4cq/IjlJUaHRGWSpLAEm loOXKdXf3S8/xmmvyPUTKaGs6i8dYqxYfm/epiMAl0q5LUVIOTjB7IN8WxsO6bxiq2bb G54vt7/xQL6IP/YkrbctQEg4hkY9dNdWSoy4u8Uh8aYbwZQSIH29hxpIUfMX4v7VkJSX ksCmCCqKlXvwRRG6o0GTgyjeoeO8aTGEGcp+sDapYEvcYBervl2GFYrcknfBCV7xycqu 1OQY44p/yoq+NbYR+bO1MxCOGhR5K94vpZZ+aXRpRWvSV1v9iuBsGhe72fsVU6iIvOsR 6mWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702562981; x=1703167781; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/3RQuNkLRKG8bKgPIldu8Ku3xY7yfi4XKy/b0IC08t8=; b=OtmHpSZBugA96zBXt/8QtC+0Bv/TrW7VgyTuh+euy/cICTzysjb46l7MUk3NLsT5wF QylZzBUog7kICwh8qDJZw8AqkCKDGXLsXHoa1zo6YKebdqlg4xBOyaKR9I3mYU8g/v8J th2nCDMDobSCQQtSDw8JIV+f/w7uvHjVw1lYIERYrIpgy66sdtujpl1hHQiVT7/UmXwu 9TxiQwghJZJWp0aGocyLkUhZog7fu2JQXVPfukLfl7NTq22Gm3IVbUj1GOpBUqZbVhQE bkYj1RoxlAzYiDr0r1HnZU3gigyPfEqA9DP2ZsFb/aQcNCkTJET2XX8l/+b0qXvMwO5g nKgw== X-Gm-Message-State: AOJu0Yw6G5PlhSxWjvf34m9dt/2KaxGDw8Lb0T1ROEowedCA6Di0PmZP 2r3wjdGOSuiNLoHiHmxfWpKRRQ== X-Google-Smtp-Source: AGHT+IE7Uwl8ErU40fjRiJ15CIiA2TLlXGFMgyYhBgUnAqaz4nDkwt0+SdGL5BjePKkDBG8sk1zFNA== X-Received: by 2002:a17:906:d96e:b0:a1c:b4d7:c78a with SMTP id rp14-20020a170906d96e00b00a1cb4d7c78amr4920685ejb.32.1702562981541; Thu, 14 Dec 2023 06:09:41 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id rm6-20020a1709076b0600b00a1bec12448csm9393020ejc.150.2023.12.14.06.09.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Dec 2023 06:09:41 -0800 (PST) Message-ID: <64e35ae0-a751-40ee-b27f-8034e7817222@linaro.org> Date: Thu, 14 Dec 2023 14:09:38 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/13] arm64: defconfig: sync with savedefconfig Content-Language: en-US To: Krzysztof Kozlowski , Arnd Bergmann , Peter Griffin , Rob Herring , krzysztof.kozlowski+dt@linaro.org, Michael Turquette , Stephen Boyd , Conor Dooley , andi.shyti@kernel.org, Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Sam Protsenko Cc: =?UTF-8?Q?Andr=C3=A9_Draszik?= , saravanak@google.com, William McVicker , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org References: <20231214105243.3707730-1-tudor.ambarus@linaro.org> <20231214105243.3707730-13-tudor.ambarus@linaro.org> <1153987b-a818-454a-a292-57f2b3898771@app.fastmail.com> <93969025-606c-4e4c-9cbc-3c8351f95adb@linaro.org> From: Tudor Ambarus In-Reply-To: <93969025-606c-4e4c-9cbc-3c8351f95adb@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/14/23 13:19, Krzysztof Kozlowski wrote: > On 14/12/2023 13:08, Arnd Bergmann wrote: Hi, Arnd, Krzysztof, Thanks for the review! >> On Thu, Dec 14, 2023, at 11:52, Tudor Ambarus wrote: >>> Sync the defconfig with savedefconfig as config options >>> change/move over time. >>> >>> Generated with the following commands: >>> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig >>> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- savedefconfig >>> cp defconfig arch/arm64/configs/defconfig > These are obvious. You cannot do it differently. This was just a prerequisite patch for the next, where I made a config builtin. Modifying defconfig shall be made in a similar manner, but it seems it's not the case (144 line change here), and that's why I considered it is worth specifying how I did it. > >>> Signed-off-by: Tudor Ambarus >>> --- >>> arch/arm64/configs/defconfig | 144 +++++++++++++---------------------- >>> 1 file changed, 55 insertions(+), 89 deletions(-) >> I usually ask for defconfig changes to be merged when someone just >> adds a single line per patch, but a 144 line change is clearly too >> big, please split this up. The truth is I didn't think we care what configs get removed after a savedefconfig. I see now after Arnd's review that we have a higher goal and savedefconfig shall be used to identify misconfiguration. > Anyway this should not go via my tree, because of possible conflicts. > This commit, so the savedefconfig, must be prepared on linux-next, which > should be mentioned in changelog for example. It also is not related to > this patchset. Please ignore this patch. Cheers, ta