devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, konrad.dybcio@linaro.org,
	krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: ipq6018: fix clock rates for GCC_USB0_MOCK_UTMI_CLK
Date: Tue, 5 Dec 2023 08:02:59 +0100	[thread overview]
Message-ID: <64ea0631-13d9-4661-bf83-05ef21a1611d@linaro.org> (raw)
In-Reply-To: <20231205030201.12694-1-amadeus@jmu.edu.cn>

On 05/12/2023 04:02, Chukun Pan wrote:
>> That does not look like XO, but GCC_USB0_MOCK_UTMI_CLK
> 
> I don't have the datasheet, but the reference clock (XO) is 24MHz, 
> and I receive the following warning:
> clk: couldn't set gcc_usb0_mock_utmi_clk clk rate to 20000000 (-22), current rate: 24000000

Referencing XO in commit  msg is confusing. Anyway, answer to such error
is not necessarily change the clock rate. What if it must be 20 MHz? You
just ignore such requirement...

Best regards,
Krzysztof


  reply	other threads:[~2023-12-05  7:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03 15:40 [PATCH v2 1/1] arm64: dts: qcom: ipq6018: fix clock rates for GCC_USB0_MOCK_UTMI_CLK Chukun Pan
2023-12-03 16:33 ` Krzysztof Kozlowski
2023-12-05  3:02   ` Chukun Pan
2023-12-05  7:02     ` Krzysztof Kozlowski [this message]
2023-12-06  3:01       ` Chukun Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64ea0631-13d9-4661-bf83-05ef21a1611d@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=amadeus@jmu.edu.cn \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).