Re: [PATCH v4 3/5] dt-bindings: mtd: spi-nor: add OTP parameters

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/09/2024 12:42, Erez wrote:
> On Tue, 17 Sept 2024 at 12:36, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 17/09/2024 11:49, Erez Geva wrote:
>>> From: Erez Geva <ErezGeva2@gmail.com>
>>>
>>> Some flash devices need OTP parameters in device tree.
>>> As we can not deduce the parameters based on JEDEC ID or SFDP.
>>>
>>> Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
>>> ---
>>>  .../bindings/mtd/jedec,spi-nor.yaml           | 37 +++++++++++++++++++
>>>  1 file changed, 37 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> index 6e3afb42926e..d502b7fab2ce 100644
>>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> @@ -90,6 +90,43 @@ properties:
>>>        the SRWD bit while writing the status register. WP# signal hard strapped to GND
>>>        can be a valid use case.
>>>
>>> +  opt_n_regions:
>>
>> No underscores, but hyphens.
> 
> I'll fix this.
> 
>>
>>> +    type: u32
>>
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
> 
> I run "make dt_binding_check" on kernel 6.6.

Yeah, we are no on kernel 6.6. You can run it also on kernel v4.1 -
still does not matter.

Don't develop on ancient code because then you ask us to review same
broken stuff we already fixed.

Best regards,
Krzysztof