From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Koskovich <akoskovich@pm.me>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Kees Cook <kees@kernel.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Add ASUS ROG Phone 3
Date: Tue, 10 Mar 2026 08:16:06 +0100 [thread overview]
Message-ID: <64f770ac-afbf-461d-b9ea-2e5467950bd2@kernel.org> (raw)
In-Reply-To: <aiez7cEpph57bS9vjzZt-ebtJRL7riKay60UUoeOmmzENyeKmvzZkc-ecTQcXjkb0d9RvfhONW4OOeK-3TgtxWy16LkOH-TRcQUq6XoDafE=@pm.me>
On 10/03/2026 04:04, Alexander Koskovich wrote:
> On Monday, March 9th, 2026 at 3:59 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
>> Please run scripts/checkpatch.pl on the patches and fix reported
>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>> patches and (probably) fix more warnings. Some warnings can be ignored,
>> especially from --strict run, but the code here looks like it needs a
>> fix. Feel free to get in touch if the warning is not clear.
>
> Ran checkpatch on v2, got a few warnings that seemed like they could be ignored
> given context but let me know if they need to be addressed:
>
> Asked for MAINTAINERS to be updated, but from what I can see there is no other
> sm8250 board that has a maintainer specifically listed.
>
> Complained about undocumented tianma,ta066vvhm03 binding, but have that
> specified as a dependency in the cover letter so ignored it.
This one. The way you wrote your cover letter does not really makes it
easy to find it. Especially that it's not even true - DTS cannot depend
on drivers.
Clearly document dependencies and new bindings used by DTS. If you are
going to mix these, your patchset will wait and will not be picked up.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-10 7:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 20:40 [PATCH 0/3] Add support for the ASUS ROG Phone 3 (SM8250) Alexander Koskovich
2026-03-08 20:40 ` [PATCH 1/3] dt-bindings: arm: qcom: Add ASUS ROG Phone 3 Alexander Koskovich
2026-03-09 7:59 ` Krzysztof Kozlowski
2026-03-10 3:04 ` Alexander Koskovich
2026-03-10 7:16 ` Krzysztof Kozlowski [this message]
2026-03-08 20:40 ` [PATCH 2/3] arm64: dts: qcom: sm8250: Add label for reserved-memory node Alexander Koskovich
2026-03-09 8:00 ` Krzysztof Kozlowski
2026-03-09 8:00 ` Krzysztof Kozlowski
2026-03-09 8:08 ` Alexander Koskovich
2026-03-09 12:40 ` Konrad Dybcio
2026-03-08 20:40 ` [PATCH 3/3] arm64: dts: qcom: sm8250-asus-obiwan: Add ASUS ROG Phone 3 Alexander Koskovich
2026-03-09 20:34 ` Dmitry Baryshkov
2026-03-10 2:57 ` Alexander Koskovich
2026-03-10 3:21 ` Dmitry Baryshkov
2026-03-10 3:32 ` Alexander Koskovich
2026-03-10 4:56 ` Alexander Koskovich
2026-03-10 11:25 ` Konrad Dybcio
2026-03-10 15:10 ` Alexander Koskovich
2026-03-11 2:40 ` Alexander Koskovich
2026-03-11 4:35 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f770ac-afbf-461d-b9ea-2e5467950bd2@kernel.org \
--to=krzk@kernel.org \
--cc=akoskovich@pm.me \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox