From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, arnd@arndb.de,
brendanhiggins@google.com, tglx@linutronix.de,
anders.roxell@linaro.org, masonccyang@mxic.com.tw,
piotrs@cadence.com, robh+dt@kernel.org,
linux-mips@vger.kernel.org, hauke.mehrtens@intel.com,
andriy.shevchenko@intel.com, qi-ming.wu@intel.com,
cheol.yong.kim@intel.com
Subject: Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Mon, 20 Apr 2020 16:51:58 +0800 [thread overview]
Message-ID: <65120cb5-9d8d-27a1-a7c1-1e88e18e00b6@linux.intel.com> (raw)
In-Reply-To: <20200420094018.6fdbda68@collabora.com>
On 20/4/2020 3:40 pm, Boris Brezillon wrote:
> On Mon, 20 Apr 2020 12:18:34 +0800
> "Ramuthevar, Vadivel MuruganX"
> <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>
>
>>>> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
>>>> index a80a46bb5b8b..9efc4bbaf4a3 100644
>>>> --- a/drivers/mtd/nand/raw/Kconfig
>>>> +++ b/drivers/mtd/nand/raw/Kconfig
>>>> @@ -457,6 +457,13 @@ config MTD_NAND_CADENCE
>>>> Enable the driver for NAND flash on platforms using a Cadence NAND
>>>> controller.
>>>>
>>>> +config MTD_NAND_INTEL_LGM
>>>> + tristate "Support for NAND controller on Intel LGM SoC"
>>>> + depends on X86
>>> Do we have a hard dependency on x86 here? Maybe 'depends on HAS_MMIO'
>>> would be enough.
>> yes Boris, we have hard dependency on x86.
> Given that the driver will also be used on a MIPS platform I would say
> no :P. Just to be clear, I was suggesting to replace the soon to emerge
>
> depends on X86 || MIPS || COMPILE_TEST
> depends HAS_IOMEM
>
> rule by
>
> depends on OF || COMPILE_TEST
> depends HAS_IOMEM
Thank you for the suggestion !
Yes, you are right since MIPS based SoCs also using the same driver, so
we can add the above rule.
Regards
Vadivel
next prev parent reply other threads:[~2020-04-20 8:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 8:21 [PATCH v2 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-17 8:21 ` [PATCH v2 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support Ramuthevar,Vadivel MuruganX
2020-04-17 8:21 ` [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-04-17 17:05 ` Hauke Mehrtens
2020-04-20 3:49 ` Ramuthevar, Vadivel MuruganX
2020-04-18 8:55 ` Boris Brezillon
2020-04-19 22:20 ` Andy Shevchenko
2020-04-20 9:17 ` Boris Brezillon
2020-04-20 9:44 ` Andy Shevchenko
2020-04-20 9:52 ` Boris Brezillon
2020-04-20 10:14 ` Andy Shevchenko
2020-04-20 10:28 ` Boris Brezillon
2020-04-20 10:41 ` Andy Shevchenko
2020-04-20 11:06 ` Boris Brezillon
2020-04-20 4:18 ` Ramuthevar, Vadivel MuruganX
2020-04-20 7:40 ` Boris Brezillon
2020-04-20 8:51 ` Ramuthevar, Vadivel MuruganX [this message]
2020-04-27 15:38 ` Miquel Raynal
2020-04-27 18:30 ` Boris Brezillon
2020-04-19 22:28 ` Andy Shevchenko
2020-04-20 3:28 ` Ramuthevar, Vadivel MuruganX
2020-04-20 8:29 ` Boris Brezillon
2020-04-20 9:15 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65120cb5-9d8d-27a1-a7c1-1e88e18e00b6@linux.intel.com \
--to=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@collabora.com \
--cc=brendanhiggins@google.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke.mehrtens@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=piotrs@cadence.com \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).