From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6358C7EE29 for ; Thu, 1 Jun 2023 08:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232024AbjFAIL6 (ORCPT ); Thu, 1 Jun 2023 04:11:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231942AbjFAIL5 (ORCPT ); Thu, 1 Jun 2023 04:11:57 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00202E2 for ; Thu, 1 Jun 2023 01:11:51 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-514924ca903so879017a12.2 for ; Thu, 01 Jun 2023 01:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685607110; x=1688199110; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a/aAPNbwdm0BPn5PUgLp4hktWQaK2+uFNT4kN1UiiV4=; b=noBu4GFo9o3K31KSzM6zLXaqNSmfMChm9oSwgyqduSqkh+q29FAY/1uCqxBNWnDE43 d36A38bwZ64J5xryHZzKKXCirlaQPolkLgkuTj3Pb7gf1KSetTMW6TL4DCTmrrW0YJCJ 8kFPneS+nrSiGsbgg1frnaP32OKmvDUSmXcwWQsIkWpQG7F5TJEHIb9rX8VXJf/dwQo+ uIOloDXkzuvmT7sLEkHBgH1woFhKHNTWj/nNRvpvGNJ3RenBcG6vT5LEoOrU5+vWiYMM d9ozFrKUIgtc++4ieYsff8RQrU482JbaPkGCCgQC+n2nE72CBBvN8GvSQCLHXoIKZM6O D8VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685607110; x=1688199110; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a/aAPNbwdm0BPn5PUgLp4hktWQaK2+uFNT4kN1UiiV4=; b=cySb1LZnGDy6pKbAaJqCq3K6lRsfSD4RjeiJwUK2BA97kdH7Hfs4WgL/88mpZKB3BW QZYKCOwJXtQMlEHg9joxXwXTcvvE+XaD1Z1uTu4LIWxGOlsBkzq74wfyLFOWe1be0eFp 98YoIgAMA75LIQ6o6fSTysBo+JnyaasOL14S070r7wSQ9GFWkyAeDU/iYgm+2ugtYUg1 H6QAHlpsxGZ900tCcfNjWaydHHQ07U6IaG1cbDpjwb4ZBjACsv9o09R1HO937AyDLH6C GuM9V3+mfuKsiApShJc/pIMIFQwuJmfDkfwKpHp4mA5E4HhfTSEBc2qE0IpppMV2glgd SsOg== X-Gm-Message-State: AC+VfDzlw545D023HXyJUWdnpPVMqnGKZBq7Vrh4qX8xCj/yw6KmHSd8 zjBRVn2hZ3wKkxk+ce7vQ4YAsg== X-Google-Smtp-Source: ACHHUZ59OUxz1x6flGeMGoLbNndoi2EK6EwfZcyjgNCpA1L9+RbhXlv0PBwyXltBSS9baZu1GRh/2A== X-Received: by 2002:a17:907:7b92:b0:96a:52e:5379 with SMTP id ne18-20020a1709077b9200b0096a052e5379mr7774277ejc.63.1685607110379; Thu, 01 Jun 2023 01:11:50 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id l17-20020a1709067d5100b0096f72424e00sm10129750ejp.131.2023.06.01.01.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 01:11:49 -0700 (PDT) Message-ID: <65124d19-474a-ce95-2cb3-bb8273a8e3b7@linaro.org> Date: Thu, 1 Jun 2023 10:11:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 23/43] dt-bindings: mtd: Add ts7250 nand-controller To: Nikita Shubin , Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski Cc: Michael Peters , Kris Bahnsen , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601054549.10843-5-nikita.shubin@maquefel.me> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230601054549.10843-5-nikita.shubin@maquefel.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/06/2023 07:45, Nikita Shubin wrote: > Add YAML bindings for ts7250 NAND Controller. > > Signed-off-by: Nikita Shubin > --- > > Notes: > v0 -> v1: > > make it a nand contoller > > .../bindings/mtd/technologic,nand.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/technologic,nand.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/technologic,nand.yaml b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml > new file mode 100644 > index 000000000000..26d1d9c3331d > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/technologic,nand.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/technologic,nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Technologic Systems NAND controller > + > +maintainers: > + - Nikita Shubin > + > +allOf: > + - $ref: nand-controller.yaml > + > +properties: > + compatible: > + oneOf: > + - const: technologic,ts7200-nand > + - items: > + - enum: > + - technologic,ts7300-nand > + - technologic,ts7260-nand > + - technologic,ts7250-nand > + - const: technologic,ts7200-nand > + > + reg: > + maxItems: 1 > + > + '#address-cells': true > + '#size-cells': true Except what Miquel wrote - drop these two. > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: true > + > +examples: > + - | > + nand-controller@60000000 { > + compatible = "technologic,ts7200-nand"; > + reg = <0x60000000 0x8000000>; > + #address-cells = <1>; > + #size-cells = <0>; Incomplete example. address/size cells do not make sense here alone. Finish the example. > + }; > + > +... Best regards, Krzysztof