From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C0EC43334 for ; Thu, 14 Jul 2022 03:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbiGNDWs (ORCPT ); Wed, 13 Jul 2022 23:22:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230055AbiGNDWr (ORCPT ); Wed, 13 Jul 2022 23:22:47 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB3F7240AA; Wed, 13 Jul 2022 20:22:45 -0700 (PDT) Received: from [10.88.19.41] (10.88.19.41) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.2176.2; Thu, 14 Jul 2022 11:22:42 +0800 Message-ID: <6543a75a-fd9f-7395-70b2-15a19d872339@amlogic.com> Date: Thu, 14 Jul 2022 11:22:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH 4/4] dt-binding:perf: Add Amlogic DDR PMU To: Krzysztof Kozlowski , , , , CC: Rob Herring , Krzysztof Kozlowski , Will Deacon , Mark Rutland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Chris Healy References: <20220712063641.2790997-1-jiucheng.xu@amlogic.com> <20220712063641.2790997-4-jiucheng.xu@amlogic.com> <1aa8e9aa-8cb3-8537-6d65-dd9441d5ee07@linaro.org> From: Jiucheng Xu In-Reply-To: <1aa8e9aa-8cb3-8537-6d65-dd9441d5ee07@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.88.19.41] Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks for your time ^^. On 7/12/2022 3:15 PM, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 12/07/2022 08:36, Jiucheng Xu wrote: >> Add binding documentation for the Amlogic G12 series DDR >> performance monitor unit. > You need to fix subject - use a prefix matching subsystem. Space after > each ':'. I will make the change. > >> Signed-off-by: Jiucheng Xu >> --- >> .../devicetree/bindings/perf/aml-ddr-pmu.yaml | 51 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml >> >> diff --git a/Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml b/Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml >> new file mode 100644 >> index 000000000000..c586b4ab4009 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml > Filename: aml,g12-ddr-pmu.yaml I will make the change. > >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/perf/aml-ddr-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic G12 DDR performance monitor >> + >> +maintainers: >> + - Jiucheng Xu >> + >> +properties: >> + compatible: >> + oneOf: >> + - enum: >> + - aml,g12-ddr-pmu >> + - items: >> + - enum: >> + - aml,g12-ddr-pmu >> + - const: aml,g12-ddr-pmu > This does not make any sense. Why do you use two compatibles > "aml,g12-ddr-pmu", "aml,g12-ddr-pmu" after each other? Sorry, I think I have a wrong understanding. I will make the change. > >> + >> + reg: >> + maxItems: 2 > You need to describe the items. I will make the change. > >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - model >> + - dmc_nr >> + - chann_nr > How these ended up here? > No underscores. I will make the change. > >> + - reg >> + - interrupts >> + - interrupt-names > Also something new. No. I will make the change. > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + ddr_pmu: ddr_pmu { > Wrong indentation. 4 spaces for DTS example. > > Generic node name, so "pmu", no underscores in node names. Okay, I will make the change. > >> + compatible = "amlogic,g12-ddr-pmu"; >> + model = "g12a"; >> + dmc_nr = <1>; >> + chann_nr = <4>; > This does not pass the test. Please do not send untested bindings. Sorry,  due to some problems, I got wrong patch sent. I will make the change. Thanks & Best Regards, Jiucheng > > > Best regards, > Krzysztof >