From: Florian Fainelli <f.fainelli@gmail.com>
To: Anand Gore <anand.gore@broadcom.com>,
Linux ARM List <linux-arm-kernel@lists.infradead.org>
Cc: kursad.oney@broadcom.com, joel.peshkin@broadcom.com,
samyon.furman@broadcom.com, tomer.yacoby@broadcom.com,
dan.beygelman@broadcom.com,
William Zhang <william.zhang@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ARM64: dts: add dts files for bcmbca SoC bcm6858
Date: Wed, 1 Jun 2022 02:48:35 -0700 [thread overview]
Message-ID: <654d35fb-c2e8-630f-be52-3369ea355d3c@gmail.com> (raw)
In-Reply-To: <20220531114551.v2.1.I66ae43da75911b704f02a759f70d66bc7e542885@changeid>
On 5/31/2022 11:46 AM, Anand Gore wrote:
> Add dts for ARMv8 based broadband SoC BCM6858.
> bcm6858.dtsi is the SoC description dts header
> and bcm96858.dts is a simple dts file for Broadcom
> BCM96858 Reference board that only enables the UART port.
>
> Signed-off-by: Anand Gore <anand.gore@broadcom.com>
>
> ---
[snip]
> + axi@81000000 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
See my comment to William, I don't think this is quite what you want,
you should use #address-cells and #size-cells = 1 here and adjust the
reg nodes accordingly.
--
Florian
next prev parent reply other threads:[~2022-06-01 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 18:46 [PATCH v2 0/3] arm64: bcmbca: add bcm6858 soc support Anand Gore
2022-05-31 18:46 ` [PATCH v2 1/3] ARM64: dts: add dts files for bcmbca SoC bcm6858 Anand Gore
2022-06-01 9:48 ` Florian Fainelli [this message]
2022-05-31 18:46 ` [PATCH v2 2/3] dt-bindings: arm64: add BCM6858 soc Anand Gore
2022-06-01 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=654d35fb-c2e8-630f-be52-3369ea355d3c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samyon.furman@broadcom.com \
--cc=tomer.yacoby@broadcom.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).