From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V2 03/15] genirq: Generic chip: Move irq_reg_{readl,writel} accessors into generic-chip.c Date: Thu, 30 Oct 2014 10:06:51 +0100 Message-ID: <6552163.gt4ABVyYlA@wuerfel> References: <1414635488-14137-1-git-send-email-cernekee@gmail.com> <1414635488-14137-4-git-send-email-cernekee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: Kevin Cernekee , f.fainelli@gmail.com, jason@lakedaemon.net, ralf@linux-mips.org, lethal@linux-sh.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mbizon@freebox.fr, jogo@openwrt.org, linux-mips@linux-mips.org List-Id: devicetree@vger.kernel.org On Thursday 30 October 2014 09:43:02 Thomas Gleixner wrote: > > diff --git a/include/linux/irq.h b/include/linux/irq.h > > index 03f48d9..8049e93 100644 > > --- a/include/linux/irq.h > > +++ b/include/linux/irq.h > > @@ -639,13 +639,6 @@ void arch_teardown_hwirq(unsigned int irq); > > void irq_init_desc(unsigned int irq); > > #endif > > > > -#ifndef irq_reg_writel > > -# define irq_reg_writel(val, addr) writel(val, addr) > > -#endif > > -#ifndef irq_reg_readl > > -# define irq_reg_readl(addr) readl(addr) > > -#endif > > - > > Brilliant patch that. > > # git grep -l irq_reg_readl drivers/irqchip/ > drivers/irqchip/irq-atmel-aic.c > drivers/irqchip/irq-atmel-aic5.c > drivers/irqchip/irq-sunxi-nmi.c > drivers/irqchip/irq-tb10x.c Patch 1/15 changes these all. I think it's still broken because patch 2/15 is wrong, but it's not /that/ obviously broken. Arnd