From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH v2 0/3] mtd: rawnand: denali: add new clocks and improve setup_data_interface Date: Thu, 14 Jun 2018 09:25:19 +0200 Message-ID: <6557713.S7AzxIg9TS@blindfold> References: <1528953067-24324-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1528953067-24324-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: linux-mtd@lists.infradead.org, Boris Brezillon , Philipp Rosenberger , Rob Herring , devicetree@vger.kernel.org, Miquel Raynal , linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse , Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org Masahiro, Am Donnerstag, 14. Juni 2018, 07:11:04 CEST schrieb Masahiro Yamada: > > The ->setup_data_interface() hook needs to know the clock frequency. > In fact, this IP needs three clocks, bus "which clock?" is really > confusing. (It is not described in the DT-binding at all.) > > This series adds more clocks. In the new binding, three clocks > are required: core clock, bus interface clock, ECC engine clock. > > This series also takes care of the backward compatibility by > providing hardcoded values in case the new clocks are missing. > So, existing DT should work. > > > Changes in v2: > - Split patches into sensible chunks > > Masahiro Yamada (3): > mtd: rawnand: denali_dt: use dev as a shorthand of &pdev->dev > mtd: rawnand: denali_dt: add more clocks based on IP datasheet > mtd: rawnand: denali: optimize timing parameters for data interface This still means that we need to feed at least 2/3 and 3/3 into -stable to unbreak the driver. I'd really prefer a single self-hosting fix that can go into -stable and then patches on top of the fix can prettify the driver. Thanks, //richard -- sigma star gmbh - Eduard-Bodem-Gasse 6 - 6020 Innsbruck - Austria ATU66964118 - FN 374287y