From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings Date: Tue, 24 Apr 2018 17:49:15 +0100 Message-ID: <655a593b-021c-3bf2-35c2-eb77cb0a4b95@linaro.org> References: <20180418153157.1960-1-srinivas.kandagatla@linaro.org> <20180418153157.1960-22-srinivas.kandagatla@linaro.org> <20180424162517.msxscjfg36xc22mo@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180424162517.msxscjfg36xc22mo@rob-hp-laptop> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rob Herring Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, rohkumar@qti.qualcomm.com, linux-arm-msm@vger.kernel.org, plai@codeaurora.org, spatakok@qti.qualcomm.com, lgirdwood@gmail.com, tiwai@suse.com, david.brown@linaro.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, andy.gross@linaro.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Thanks for the review. On 24/04/18 17:25, Rob Herring wrote: > On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandagatla@linaro.org wrote: >> From: Srinivas Kandagatla >> >> Add devicetree bindings documentation file for Qualcomm apq8096 sound card. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> .../devicetree/bindings/sound/qcom,apq8096.txt | 76 ++++++++++++++++++++++ >> 1 file changed, 76 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8096.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt >> new file mode 100644 >> index 000000000000..37e23d926b95 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt >> @@ -0,0 +1,76 @@ >> +* Qualcomm Technologies APQ8096 ASoC sound card driver >> + >> +This binding describes the APQ8096 sound card, which uses qdsp for audio. >> + >> +- compatible: >> + Usage: required >> + Value type: >> + Definition: must be "qcom,apq8096-sndcard" >> + >> +- qcom,audio-routing: >> + Usage: Optional >> + Value type: >> + Definition: A list of the connections between audio components. >> + Each entry is a pair of strings, the first being the >> + connection's sink, the second being the connection's >> + source. Valid names could be power supplies, MicBias >> + of codec and the jacks on the board: > > Please list out valid values here. I can list the values for the HDMI playback use-case, but the list would grow as we start adding wcd9335 codec support. > >> + >> += dailinks >> +Each subnode of sndcard represents either a dailink, and subnodes of each >> +dailinks would be cpu/codec/platform dais. >> + >> +- link-name: > > Not a standard property, but I guess that sneaked in with the 8016 > binding... Yes, I followed 8016 bindings. Am happy to prefix this with qcom if that makes more sense. > >> + Usage: required >> + Value type: >> + Definition: User friendly name for dai link >> + >> += CPU, PLATFORM, CODEC dais subnodes >> +- cpu: >> + Usage: required >> + Value type: >> + Definition: cpu dai sub-node >> + >> +- codec: >> + Usage: Optional >> + Value type: >> + Definition: codec dai sub-node >> + >> +- platform: >> + Usage: Optional >> + Value type: >> + Definition: platform dai sub-node >> + >> +- sound-dai: >> + Usage: required >> + Value type: > > phandle with args. Yep. --srini