From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9713C4321E for ; Wed, 9 Feb 2022 09:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235532AbiBIJli (ORCPT ); Wed, 9 Feb 2022 04:41:38 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:49578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239767AbiBIJeW (ORCPT ); Wed, 9 Feb 2022 04:34:22 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE76EE05B1EE for ; Wed, 9 Feb 2022 01:34:18 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 6A98C4004B for ; Wed, 9 Feb 2022 08:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644397116; bh=j1Hd4lmSTFrkTOOqYMK0Qe55KdcJKzmf7To8MW6/JyA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R1vuwi9m/0P0TmV9pNo4eKaLnScaY9m4dBcKBq5idGVJoyP6rsAe1BJ2PUWtLLaaY B6sOJ1yQi3YP0bKab0HZA2myhVkiwq4OI8LZnVP0SJFGAk4LHYmgFU8EEIt215xf2e ekOe+gRYzZ/+MqLoDowDuZ0wWiLkFmg/Fu4s1Eztl0sM05iq+pf0aell6o3ex9udzE A85TV73/HTQtxqV/RfIDEutxELI2/Qz/WxdGpppsA6cQqJsao5IdJDM9O+u3kd2s5X dAJVs+ovnaiC7Xh+Knp8IdNR2Hgkzu1Ift58RQt+xKLi98VmqXrmfXaHkbUf0dM5MS J2QqA6o1VGy+A== Received: by mail-ed1-f70.google.com with SMTP id 30-20020a508e5e000000b0040f6642e814so965482edx.19 for ; Wed, 09 Feb 2022 00:58:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=j1Hd4lmSTFrkTOOqYMK0Qe55KdcJKzmf7To8MW6/JyA=; b=kPGoe9DtueLpPI8tEiT3eq20bmHOJRG4U5/ohOmvOw2VG2j0zNKHWrBQvF71/ieKEK opff8ogaypZtR9MHHzwIma0j33YIwTkdZT6YgcBV581iR04MwOgxhjk1jI68zkgR3REj l7mcOP7Kb4B4idFslq0dVKmvvgUrML+EyofzI7cToOqpz/fOrCYZV8vrOcl/imrBzpRB ol3/zwabYlwf1CQ2+IDEP8LVoIDqht8ToydgaCU4o9knqLIw2yj/lNZ1qCGQGGAfGBc2 zQhBr9mvAQJPEb1oPMFj2veuSXvTNicYy7ZnAlxrtNneAmOO8as90HwLgRjhAX1NnCPa DKQg== X-Gm-Message-State: AOAM531at0jBziC1jJSrCrsjiDJvSUrj3D7vx5VqrV/UkN2Xawby0bPS HyuC9wQC5lgHeZgf7uF8Vj7G84g/AKZqGOqo8lhk7RYEXk/NbiYf1BpT+LB67PTlnYq1NwJha2l b/piRSShUjtl66AxMbx+1/iYNFHosYC/Xdk9nuTc= X-Received: by 2002:a05:6402:268d:: with SMTP id w13mr1336044edd.287.1644397115850; Wed, 09 Feb 2022 00:58:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLa/snmtz5iqx9Hn8j3YbAXkBMWCsfLkv0xITTQmx8XEZnlMbvesoWqn0aMi8P2fY5Dqr93Q== X-Received: by 2002:a05:6402:268d:: with SMTP id w13mr1336029edd.287.1644397115699; Wed, 09 Feb 2022 00:58:35 -0800 (PST) Received: from [192.168.0.94] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id g11sm3820460ejs.14.2022.02.09.00.58.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 00:58:35 -0800 (PST) Message-ID: <6568fd31-113f-1581-4eff-45a4a1eb4e5d@canonical.com> Date: Wed, 9 Feb 2022 09:58:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 3/9] dt-bindings: memory: lpddr2: Add revision-id properties Content-Language: en-US To: Julius Werner , Dmitry Osipenko Cc: Rob Herring , linux-tegra@vger.kernel.org, Rob Herring , Jonathan Hunter , devicetree@vger.kernel.org, LKML , Thierry Reding References: <20211006224659.21434-1-digetx@gmail.com> <20211006224659.21434-4-digetx@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/02/2022 00:46, Julius Werner wrote: >> Unfortunately I have no clue what patch you talk about ("this patch"). >> There is no context here, no link except the older LPDDR3. > > Sorry, I tried to reply to > https://lore.kernel.org/all/20211006224659.21434-4-digetx@gmail.com/ > ([PATCH v5 3/9] dt-bindings: memory: lpddr2: Add revision-id > properties) and was hoping that would automatically provide context. > That patch added two one-cell properties `revision-id1` and > `revision-id2` to "jedec,lpddr2". Earlier in > https://www.spinics.net/lists/devicetree/msg413733.html ([PATCH] > dt-bindings: ddr: Add optional manufacturer and revision ID to > LPDDR3), I had added a single two-cell property `revision-id` for the > same purpose to "jedec,lpddr3". > > I think it would be better if this was consistent between the two > types of LPDDR memory. Should I just send a patch that replaces the > two revision IDs in "jedec,lpddr2" with a single one according to the > principle of "jedec,lpddr3"? Or is it too late for that now and the > binding already considered stable and unchangeable? Hi Julius, Having same bindings for revision ID makes sense. Sadly this was not spotted during review, eh, life... Unfortunately the bindings are already in a mainline release, so they are considered stable. You can however bring patches (bindings + drivers/memory/of + dts) which make the revision-id[12] deprecated and introduce new revision-id. It should be something similar to what I did for max-freq: https://lore.kernel.org/all/20220206135807.211767-7-krzysztof.kozlowski@canonical.com/ Dmitry, Any early comments on such approach from you? Best regards, Krzysztof