From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E22BC71145 for ; Thu, 24 Aug 2023 06:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236297AbjHXGiG (ORCPT ); Thu, 24 Aug 2023 02:38:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240150AbjHXGhq (ORCPT ); Thu, 24 Aug 2023 02:37:46 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4273210F7 for ; Wed, 23 Aug 2023 23:37:43 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-99bed101b70so827259466b.3 for ; Wed, 23 Aug 2023 23:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692859061; x=1693463861; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A5fZt6Ihkc3G2cDG6LVOei+M0bpuMD5Ug5ycUdw4MKc=; b=wx45oOvnvkIna3h2LmYOLydvEnXg4o46Qs99Rkl3mS6KUN/wwOirMjfMi1lppx+HS2 OAufrP5OD4sc1QbIxkXhFfAJxxsdTiKrcDeduQ3yXzO+7LCc9m4Gi2t/wOwBb325g1Bu QksGYMpB5QpFBjtyk8n7f8832dbhzPKbb9liqtMxod7Xdi7IQIOeRDo8sHYeRNumD7tm YCQ90uZ9IUVHQIzxSS3UbkhSaujbed52S2Sfdh9szzbYCmls7Eq6mYKFc+wSCb/M5pjV iGmmLof3Wf3Le3rabIyaTScmSAhXoFtI9n+IDiiuPB6MONRQHc23/u7HBwX4mj42CrrI yQ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692859061; x=1693463861; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A5fZt6Ihkc3G2cDG6LVOei+M0bpuMD5Ug5ycUdw4MKc=; b=XbitPSJ5XEa/0rDDIYxjTMgacVV1wVdiixNE53WHvve5E9QH72RnYSmHWmrYqdSl/a 9vocFMTkEUomq3r2BPyxkGkQBUicDVKb5dN9WxBO/9ESb3dL9WoQcVLV4kQ6jcNbu/d7 Aa3vFQGbIeGfQnjEYvlGfNTFNw8hlxE6HBn4qM610tfrpT98ZeJBf27IO8jR83ZEW02D xuBl5s3TgTgmUAuphIq8LMBCr6mLi6ea1LaAIRackDlGpmjxYR9l8TFzmfeXjFqrc8+x 7Me3qY6tUfph6N7fWIpOod0SEs2GN7GitQhv41udqqloD3VKFlV/jN3W3TCpnQm8fJDj 77YA== X-Gm-Message-State: AOJu0YzNkbovUaSxL04Jo2Qah28ewq1PlHmzio9R/5k69g7BbbJ3KBG4 6GlqNd9bxBcbSVVRVbbBVEYA5w== X-Google-Smtp-Source: AGHT+IGoDmzSJBNnU9nBS0McctkvqxjQkn8ai4uzfqjiY8PRizioW/1k/iggqzE+u4Fi0nsu6nS7+w== X-Received: by 2002:a17:906:5347:b0:9a1:ec69:23ec with SMTP id j7-20020a170906534700b009a1ec6923ecmr2562516ejo.17.1692859061599; Wed, 23 Aug 2023 23:37:41 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id t16-20020a1709064f1000b0099297c99314sm9616794eju.113.2023.08.23.23.37.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 23:37:41 -0700 (PDT) Message-ID: <6574894d-e7ba-e5cc-a03f-76f97d1403ad@linaro.org> Date: Thu, 24 Aug 2023 08:37:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/2] dt-bindings: crypto: qcom,prng: document SM8550 Content-Language: en-US To: Om Prakash Singh , neil.armstrong@linaro.org, Konrad Dybcio , Andy Gross , Bjorn Andersson , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230822-topic-sm8550-rng-v1-0-8e10055165d1@linaro.org> <20230822-topic-sm8550-rng-v1-1-8e10055165d1@linaro.org> <8479869b-9984-41e3-9812-c7f5727cfd2c@linaro.org> <26bae022-c114-4871-8715-73d7e8aeaa52@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/08/2023 01:32, Om Prakash Singh wrote: > > > On 8/23/2023 1:25 PM, Neil Armstrong wrote: >> Hi, >> >> On 23/08/2023 02:10, Om Prakash Singh wrote: >>> >>> >>> On 8/22/2023 9:34 PM, Konrad Dybcio wrote: >>>> On 22.08.2023 16:54, Om Prakash Singh wrote: >>>>> PRNG Block on most of newer target from Qualcomm have some >>>>> configuration where clock is configured by security firmware. >>>>> >>>>> Adding separate compatible string for each platform is overhead. >>>>> >>>>> We need to introduce common compatible string that can be used for >>>>> all platforms with same configuration. >>>>> >>>>> I would suggest to use "qcom,rng-ee" for newer platform, dropping >>>>> "p" also signifies it is not a Pseudo Random Number Generator. >>>> Please reply inline and don't top-post. >>>> >>>> >>>> Is this what you're trying to say? >>>> >>>> 1. sort out the clock requirements for designs where Linux manages it >>>>     vs where the FW does so > >>>> 2. introduce a new compatible for SoCs implementing a TRNG >>>> >>>> 3. for SoCs in 2., register the TRNG as a hwrng device >>> >>> Yes to all >> >> I can send a proposal, but that means writing a new driver for this >> compatible in drivers/char/hw_random/ right ? > > We can add hwrng support in same driver like > drivers/crypto/hisilicon/trng/trng.c > > As Krzysztof is suggesting we need to have platform specific compatible That's independent question > string, we can go with your change. for hwrng support I will send > separate patches. Any bindings decision should be made now. We don't produce knowingly incomplete bindings just to change them later. Therefore now you need to decide whether you call it prng-ee or something else. Best regards, Krzysztof