From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs
Date: Mon, 11 Dec 2023 16:49:00 +0100 [thread overview]
Message-ID: <65772f6f.050a0220.8a2bb.80c7@mx.google.com> (raw)
In-Reply-To: <242759d9-327d-4fde-b2a0-24566cf5bf25@lunn.ch>
On Mon, Dec 11, 2023 at 04:44:06PM +0100, Andrew Lunn wrote:
> > +properties:
> > + qca,led-active-high:
> > + description: Set all the LEDs to active high to be turned on.
> > + type: boolean
>
> I would of expected active high is the default. An active low property
> would make more sense. It should also be a generic property, not a
> vendor property. As such, we either want the phylib core to parse it,
> or the LED core.
>
Also sorry for the double email... Any help for the problem of the
missing link_2500 define in net-next? (merged in Lee tree?)
--
Ansuel
next prev parent reply other threads:[~2023-12-11 15:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 1:48 [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs Christian Marangi
2023-12-09 1:48 ` [net-next PATCH 2/2] net: phy: at803x: add LED support for qca808x Christian Marangi
2023-12-09 12:38 ` kernel test robot
2023-12-09 12:44 ` Christian Marangi
2023-12-11 15:50 ` Andrew Lunn
2023-12-09 18:24 ` kernel test robot
2023-12-11 10:19 ` [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs Krzysztof Kozlowski
2023-12-11 12:18 ` Christian Marangi
2023-12-11 16:01 ` Krzysztof Kozlowski
2023-12-11 15:44 ` Andrew Lunn
2023-12-11 15:48 ` Christian Marangi
2023-12-11 15:54 ` Andrew Lunn
2023-12-11 17:19 ` Christian Marangi
2023-12-11 17:49 ` Andrew Lunn
2023-12-11 17:57 ` Christian Marangi
2023-12-11 15:49 ` Christian Marangi [this message]
2023-12-11 15:51 ` Andrew Lunn
2023-12-11 15:57 ` Christian Marangi
2023-12-13 18:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65772f6f.050a0220.8a2bb.80c7@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).