From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B04AC636D4 for ; Thu, 2 Feb 2023 14:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229690AbjBBOBT (ORCPT ); Thu, 2 Feb 2023 09:01:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231725AbjBBOBR (ORCPT ); Thu, 2 Feb 2023 09:01:17 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB52B72648 for ; Thu, 2 Feb 2023 06:01:15 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id d14so1783276wrr.9 for ; Thu, 02 Feb 2023 06:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GR8KgSL36Lkyc27jhe9VelRangL80momgo8oQ8ZkJ3E=; b=PbfB2SCfdyo87K53ROkt1vXqLqNSCVF3uzv0x98v0Jezk1m5kgz4qiJzhkqFP5iEdc wgDU7Wab/UGF2LM91NjKXvkNFau7YeVo+dW88/zx6IPUULOTLblnRIHX1KwnIYkegLm5 EmXtfY0LaAxTFEXZwegvisGONRnE7XjQXhGncrc5m2i9dlwxcIGdVg4uq1e5nBQFpP36 /NUlZusWUV55NMN5Hob6/I/+UrQdkWH8dAsAMaDwU3pFDSnCGxJqLOr5alUPVEr/D7+B lIwOfTZ00y9lx0OWHuXmk13p3lOe6iD6+fggffj6w+CBASBEW1wBgbuGsSPf5M25kYf3 2/Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GR8KgSL36Lkyc27jhe9VelRangL80momgo8oQ8ZkJ3E=; b=qTNRTmNVqZfW4GNXkRMxU5FwAMDWwCJjS8bhxyeBTxKszacMn1tkRkskdzHXyrUZ3S xj+YOHh1eJsit8/jtZUPD3CytAMvB+R9Nwb9/DXUcNh4+f/oUrvqk3Dw/bR+HinpH9Fu pz7N19lXnsqMNOAeHos4bsUDpq2+w1GLtVZI0xtEqmyGEeRZuFYy81ntr19+Vb7FLwnK 6qCVhSoztu+kUvY+UUiT/Fu5FLm66Wh8ZtWtjPMKQL3FQSqDuzUvHC7mGGq/rsQBM2DD myFx21qeEkTZYXWjPbdYlgI0O1uErUvFSUDJ+clePuSWK8a1wIt0Gb4dQ4XOBlasLNt5 G8aA== X-Gm-Message-State: AO0yUKXB9kRbDnBR0dThWaztidyhHQMkJc5BjIB31REeNuEG9uZnYHFj lfYzKdG4Xo1kTOPyipWrZPGYXg== X-Google-Smtp-Source: AK7set9/JLUR+StvC64CszQqDkQBR15P3RrIfhgfe8877fqoj5oa4e40mUa3+jZywiWu8SKojqmURA== X-Received: by 2002:a5d:6203:0:b0:2bf:ed6c:2344 with SMTP id y3-20020a5d6203000000b002bfed6c2344mr5722157wru.9.1675346474323; Thu, 02 Feb 2023 06:01:14 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id w10-20020adfcd0a000000b002bff7caa1c2sm9024426wrm.0.2023.02.02.06.01.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 06:01:13 -0800 (PST) Message-ID: <6577abf2-7717-b952-13d7-9143200f24fc@linaro.org> Date: Thu, 2 Feb 2023 15:01:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v8 9/9] crypto: qce: core: Add new compatibles for qce crypto driver Content-Language: en-US To: Vladimir Zapolskiy , Krzysztof Kozlowski , Bjorn Andersson , Herbert Xu , Thara Gopinath , Bhupesh Sharma Cc: Rob Herring , Konrad Dybcio , Andy Gross , "David S. Miller" , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, Rob Herring , Jordan Crouse References: <20230202135036.2635376-1-vladimir.zapolskiy@linaro.org> <20230202135036.2635376-10-vladimir.zapolskiy@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230202135036.2635376-10-vladimir.zapolskiy@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/02/2023 14:50, Vladimir Zapolskiy wrote: > From: Bhupesh Sharma > > Since we decided to use soc specific compatibles for describing > the qce crypto IP nodes in the device-trees, adapt the driver > now to handle the same. > > Keep the old deprecated compatible strings still in the driver, > to ensure backward compatibility. > > Cc: Bjorn Andersson > Cc: Rob Herring > Cc: herbert@gondor.apana.org.au > Tested-by: Jordan Crouse > Signed-off-by: Bhupesh Sharma > [vladimir: added more SoC specfic compatibles] > Signed-off-by: Vladimir Zapolskiy > --- > drivers/crypto/qce/core.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 8e496fb2d5e2..2420a5ff44d1 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -291,8 +291,20 @@ static int qce_crypto_remove(struct platform_device *pdev) > } > > static const struct of_device_id qce_crypto_of_match[] = { > + /* Following two entries are deprecated (kept only for backward compatibility) */ > { .compatible = "qcom,crypto-v5.1", }, > { .compatible = "qcom,crypto-v5.4", }, > + /* Add compatible strings as per updated dt-bindings, here: */ > + { .compatible = "qcom,ipq4019-qce", }, > + { .compatible = "qcom,ipq6018-qce", }, > + { .compatible = "qcom,ipq8074-qce", }, > + { .compatible = "qcom,msm8996-qce", }, > + { .compatible = "qcom,sdm845-qce", }, > + { .compatible = "qcom,sm8150-qce", }, > + { .compatible = "qcom,sm8250-qce", }, > + { .compatible = "qcom,sm8350-qce", }, > + { .compatible = "qcom,sm8450-qce", }, > + { .compatible = "qcom,sm8550-qce", }, I did not agree with this at v7 and I still do not agree. We already did some effort to clean this pattern in other drivers, so to make it clear - driver does not need 10 compatibles because they are the same. And before anyone responds that we need SoC-specific compatibles, yes, we need them, its is obvious, but in the bindings. Not in the driver. Please go with SoC compatible fallback, as many times encouraged by Rob. Worst case go with generic fallback compatible. Best regards, Krzysztof