From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manorit Chawdhry <m-chawdhry@ti.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, J Keerthy <j-keerthy@ti.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Udit Kumar <u-kumar1@ti.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] dt-bindings: thermal: k3-j72xx: Update bindings for J721S2 SoCs
Date: Thu, 4 Jan 2024 10:33:04 +0100 [thread overview]
Message-ID: <65a294e7-1c3c-4022-9498-e83e7415ffb3@linaro.org> (raw)
In-Reply-To: <20231228-b4-upstream-j721s2-vtm-dt-binding-v1-1-e866277f9c64@ti.com>
On 28/12/2023 07:39, Manorit Chawdhry wrote:
> The clock and processor ID for J721S2 differs from the existing
> compatibles, add a new compatible to represent this change for adding
> support for Adaptive voltage scaling.
Subject: everything is "update". Write proper subjects.
A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
> .../devicetree/bindings/thermal/ti,j72xx-thermal.yaml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> index 171b3622ed84..5792ccc058aa 100644
> --- a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> @@ -24,9 +24,13 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - ti,j721e-vtm
> - - ti,j7200-vtm
> + anyOf:
? Eh, what?
> + - items:
> + - enum:
> + - ti,j721e-vtm
> + - ti,j7200-vtm
> + - ti,j721s2-vtm
> + - maxItems: 2
What? I really do not understand what are you doing here.
>
> reg:
> items:
> @@ -72,7 +76,7 @@ examples:
> - |
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
> wkup_vtm0: thermal-sensor@42040000 {
> - compatible = "ti,j721e-vtm";
> + compatible = "ti,j721e-vtm", "ti,j7200-vtm";
It's an enum, not a list.
NAK, please read example-schema and other bindings. Then get review from
TI folks before posting new versions.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-04 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 6:39 [PATCH] dt-bindings: thermal: k3-j72xx: Update bindings for J721S2 SoCs Manorit Chawdhry
2024-01-04 9:33 ` Krzysztof Kozlowski [this message]
2024-01-04 15:20 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a294e7-1c3c-4022-9498-e83e7415ffb3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=m-chawdhry@ti.com \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).