From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5F1C001DB for ; Tue, 8 Aug 2023 16:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233669AbjHHQyc (ORCPT ); Tue, 8 Aug 2023 12:54:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232831AbjHHQx6 (ORCPT ); Tue, 8 Aug 2023 12:53:58 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF474FB21 for ; Tue, 8 Aug 2023 08:58:52 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4fe48a2801bso9624915e87.1 for ; Tue, 08 Aug 2023 08:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691510325; x=1692115125; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vsp33dBf7UhgamzOkYxOzQdC3CHLd9zXwnmRE8U0OWI=; b=tGiVBPIrLdvP+nAOHek8NtRw1pVTfjx0jm2R1bPN8gfpXo2UsTg3GvErn3ZbMNmy++ GuaH4eQwliU5sC3FuHqRujNebn6CwB/3adyVQflSS8bwFq9pJg2yC3ptItPkYRUcqdSK e7mODTnEdfn2cOyw5VB9IyRpLVqPFt+LaihlExdKk2bBwfnVM2LDLpTfXMEzno9nWNhR 5OF0w+Oq5cHC/M9j4z26Z2GAW4I6f1o2YJaDKeFuRdM450ZUY/lBoKRVwNsHqC6vrId+ 6RPtMyqSulBZgNzHLmTfc1uKW7lu3LErQN148mtV4rbLaR8AHFC4HWv8rqRihwDlRoeZ c3Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691510325; x=1692115125; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vsp33dBf7UhgamzOkYxOzQdC3CHLd9zXwnmRE8U0OWI=; b=Y9YocQkGD38p+zN9uMtvZEXiGaO1+/nfoyex9joz6uRks8I16kyJuZ+mXDxm6tdhVl BAAMD5OqFV1HqUjh96GQsISW37OGxnniaYnNoAEJOtNhBdbeYDg2BGSKEX+8VUKGEceL fs2AbOG7WagH88QxLWkJNry9UmDmrqTZOH+vMhrbR8lfZEM/02QXGhoVei8d6r5DcKFx ItrYWm99aCBOstLIZDeB0yxCeQLghrBkkN+Ud3fyomhyBc2gOB47e4ZA3xObe+Onqd6S c19mW635CmbAZMfZp+/NQJAO2NmrjgGfRowuHflGEgQ+XV4naAPqJihP9qqjRBZ/c11U o9jQ== X-Gm-Message-State: AOJu0YzmKFUTjBFgGfo9KWwgoaMfbpcH535O/ePGMYVMzmDzmxDvCEqZ TuKdcszRs85uBnzSu5eSwoTuNVE1xIuujWlhyGY= X-Google-Smtp-Source: AGHT+IHJ3hZ82wubWYBzU8TJVHIOBqyUG04wm6z7DeM5yDPFDtsTGPypfW+gUnZ0OMkFJqxWx8oYeQ== X-Received: by 2002:a2e:7e0b:0:b0:2b6:ed80:15d1 with SMTP id z11-20020a2e7e0b000000b002b6ed8015d1mr8862529ljc.24.1691506333010; Tue, 08 Aug 2023 07:52:13 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id v8-20020a170906180800b009934855d8f1sm6817973eje.34.2023.08.08.07.52.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 07:52:12 -0700 (PDT) Message-ID: <65a57225-43d5-fdfa-c12d-3f33f8e535be@linaro.org> Date: Tue, 8 Aug 2023 16:52:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added nxp secure enclave fw Content-Language: en-US To: Pankaj Gupta , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "clin@suse.com" , "conor+dt@kernel.org" , "pierre.gondois@arm.com" , Jacky Bai , Clark Wang , Wei Fang , Peng Fan , Bough Chen , "festevam@gmail.com" , dl-linux-imx , "davem@davemloft.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gaurav Jain , "alexander.stein@ew.tq-group.com" , Sahil Malhotra , Aisheng Dong , Varun Sethi References: <20230712121219.2654234-1-pankaj.gupta@nxp.com> <20230712121219.2654234-5-pankaj.gupta@nxp.com> <29cb4426-a15e-7186-1713-427f749bc187@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/08/2023 13:49, Pankaj Gupta wrote: > > >> -----Original Message----- >> From: Pankaj Gupta >> Sent: Tuesday, August 8, 2023 5:04 PM >> To: Krzysztof Kozlowski ; >> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; >> clin@suse.com; conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai >> ; Clark Wang ; Wei Fang >> ; Peng Fan ; Bough Chen >> ; festevam@gmail.com; dl-linux-imx > imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; linux-arm-kernel@lists.infradead.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain >> ; alexander.stein@ew.tq-group.com; Sahil Malhotra >> ; Aisheng Dong ; Varun >> Sethi >> Subject: RE: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added >> nxp secure enclave fw >> >> >> >>> -----Original Message----- >>> From: Krzysztof Kozlowski >>> Sent: Thursday, July 13, 2023 12:38 AM >>> To: Pankaj Gupta ; shawnguo@kernel.org; >>> s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com; >>> conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai >>> ; Clark Wang ; Wei Fang >>> ; Peng Fan ; Bough Chen >>> ; festevam@gmail.com; dl-linux-imx >> imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; >>> krzysztof.kozlowski+dt@linaro.org; >>> linux-arm-kernel@lists.infradead.org; >>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain >>> ; alexander.stein@ew.tq-group.com; Sahil Malhotra >>> ; Aisheng Dong ; >> Varun >>> Sethi >>> Subject: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added >>> nxp secure enclave fw >>> >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using >>> the 'Report this email' button >>> >>> >>> On 12/07/2023 14:12, Pankaj Gupta wrote: >>>> Added support for NXP secure enclave called EdgeLock Enclave >>>> firmware >>>> (se-fw) for imx93-11x11-evk. >>>> >>>> Signed-off-by: Pankaj Gupta >>>> --- >>>> arch/arm64/boot/dts/freescale/imx93.dtsi | 11 ++++++++++- >>>> 1 file changed, 10 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> index 8643612ace8c..2b0f901d2709 100644 >>>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> @@ -1,6 +1,6 @@ >>>> // SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>> /* >>>> - * Copyright 2022 NXP >>>> + * Copyright 2022-2023 NXP >>>> */ >>>> >>>> #include @@ -863,5 +863,14 @@ >>>> ddr-pmu@4e300dc0 { >>>> reg = <0x4e300dc0 0x200>; >>>> interrupts = ; >>>> }; >>>> + >>>> + ele_fw: se-fw { >>>> + compatible = "fsl,imx93-ele"; >>>> + mboxes = <&s4muap 0 0 &s4muap 1 0>; >>> >>> This should be two entries. >>> >>>> + mbox-names = "tx", "rx"; >>>> + fsl,mu-did = <3>; >>>> + fsl,mu-id = <2>; >>> >>> Drop both. Since you put it into the DTSI, it means it is compatible specific. >> [Pankaj] Removed the above three entries. > > > [Pankaj] Correction: > I missed to note that in our up-coming SoC(s), there will be multiple MU(s): > Those can only be identified using mu_id. Hence, following two only, will be removed: > + mbox-names = "tx", "rx"; > + fsl,mu-did = <3>; Which SoC? How the bindings are going to look like for that SoC? What is mu-did in such case and how does it relate to different mailboxes? Why it cannot be inferred from compatible? BTW, responding three weeks after my review does not help your case. I totally loose the context. Of course you can reply even after 1 year, it's your right, but it does not help the discussion. Best regards, Krzysztof