From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Robert Marko <robert.marko@sartura.hr>,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 1/3] dt-bindings: net: ipq4019-mdio: document now supported clock-frequency
Date: Wed, 24 Jan 2024 23:27:20 +0100 [thread overview]
Message-ID: <65b18ecb.5d0a0220.e8e31.c94c@mx.google.com> (raw)
In-Reply-To: <010becc5-51f6-44c1-863e-f5092ca5018c@lunn.ch>
On Wed, Jan 24, 2024 at 11:23:05PM +0100, Andrew Lunn wrote:
> > + clock-frequency:
> > + description:
> > + The MDIO bus clock that must be output by the MDIO bus hardware, if
> > + absent, the default hardware values are used.
> > +
> > + MDC rate is feed by an external clock (fixed 100MHz) and is divider
> > + internally. The default divider is /256 resulting in the default rate
> > + applied of 390KHz.
> > + enum: [ 390625, 781250, 1562500, 3125000, 6250000, 12500000 ]
>
> Hi Christian
>
> 802.3 says the clock should be up to 2.5MHz by default. So the nearest
> would be 1562500. Please document that if not set, it defaults to
> this. And make the driver actually default to that.
>
As I said, this is very fk up and default value is 390KHz unless anyone
in the chain sets it (sometime uboot does it but it's not that common...
default qsdk uboot doesn't do that for example)... Ok I have to change
this to default to 1562500.
--
Ansuel
next prev parent reply other threads:[~2024-01-24 22:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 21:36 [net-next PATCH 0/3] net: mdio-ipq4019: fix wrong default MDC rate Christian Marangi
2024-01-24 21:36 ` [net-next PATCH 1/3] dt-bindings: net: ipq4019-mdio: document now supported clock-frequency Christian Marangi
2024-01-24 22:23 ` Andrew Lunn
2024-01-24 22:27 ` Christian Marangi [this message]
2024-01-24 22:38 ` Andrew Lunn
2024-01-26 11:47 ` Krzysztof Kozlowski
2024-01-24 21:36 ` [net-next PATCH 2/3] net: mdio: ipq4019: add support for clock-frequency property Christian Marangi
2024-01-24 21:36 ` [net-next PATCH 3/3] arm64: dts: qcom: ipq8074: add clock-frequency to MDIO node Christian Marangi
2024-01-25 5:57 ` [net-next PATCH 0/3] net: mdio-ipq4019: fix wrong default MDC rate Jie Luo
2024-01-25 11:36 ` Christian Marangi
2024-01-25 17:18 ` Andrew Lunn
2024-01-26 16:03 ` Jie Luo
2024-01-26 17:20 ` Dmitry Baryshkov
2024-01-26 17:33 ` Christian Marangi
2024-01-29 13:59 ` Jie Luo
2024-01-29 14:25 ` Christian Marangi
2024-01-29 15:29 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b18ecb.5d0a0220.e8e31.c94c@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).