From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51851C4321E for ; Tue, 29 Nov 2022 13:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232294AbiK2NaY (ORCPT ); Tue, 29 Nov 2022 08:30:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232299AbiK2NaX (ORCPT ); Tue, 29 Nov 2022 08:30:23 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252F462E98 for ; Tue, 29 Nov 2022 05:30:21 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id r8so16963930ljn.8 for ; Tue, 29 Nov 2022 05:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/i/Bzc17DzJULUPArLwbWH3dtwdHj5k6eH+Ns1LxYC8=; b=uEG9DdbgSVGkP+7a2JpzUDoOE6jB3Xt6w1atQHc0MhHqkjSdsHRkYJuecsAYEYWUZ9 Yz1Y2HAzqIZJ7WTZESOOEezQa4PZpvd9/CRcRgfhnPLuoI2AxsV85L3TMO8o2y2l6xF+ albLwHWeHsAjb0if/b/b1wg6dRsgii7LMYT36gIuqbMS9zXq0jtRoNOUjy949AjsjNkR 2+Iorx2cs+93b85Hpx6P+mFEf54W/Mnz8RwZxQJG61Kh85I0FDem5cTCQLTb350OF5RR zmVvB7JKmpCPil4fofRsO5WHBPDopFRS0hJuJaukYksroESui8nuvSfO8HiSxF/0uFHz vOPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/i/Bzc17DzJULUPArLwbWH3dtwdHj5k6eH+Ns1LxYC8=; b=S+j20zQtPKfdMtyxBsjq9IZC5wgwrtG1qT1uqHwOG8yV8xYJeyhFFOgHHQCu2pX/as kyzLotH7SYPmrxBQfkrRCC895yRxOavS4BpvzZAe2TgkuuakT6X6lKLGH+icJyoPfN10 lNJZAz2xmibBmKreO4ByfTbpKlHftE44Ia2PY0ZZoVCqp1Eas5gbJMWhsQOtkbM3CvS3 9f7fx6gLPwhB290YPqvfal4HrBxLpMLWvgyT4vYp82fSnZu4De0ecDZc6aSmg/57Q94f 7QDwdC5yvXO4gzOd7QlFupvf50EJG5pFHAp39j1NxG8nS0MPcRBiJxPp0DEfPpfCyyyh 3mCw== X-Gm-Message-State: ANoB5plrOmQ1oTLCfDyVOinz7ST2LYVCctls1VheGMkt/J9Z44Kawadq 26BlbWK5YIPTfvcg+LoUMerzeA== X-Google-Smtp-Source: AA0mqf6wScuI0Rf44kujd7IhwFR09ZuCRV2bqZDezbGBkhaMhklTYpRyB7rBjhBwNgXpYLXxgASMwQ== X-Received: by 2002:a2e:9611:0:b0:276:b134:b04c with SMTP id v17-20020a2e9611000000b00276b134b04cmr12646287ljh.492.1669728619532; Tue, 29 Nov 2022 05:30:19 -0800 (PST) Received: from [192.168.1.101] (95.49.125.236.neoplus.adsl.tpnet.pl. [95.49.125.236]) by smtp.gmail.com with ESMTPSA id u9-20020a2ea169000000b002776ce08326sm1533662ljl.29.2022.11.29.05.30.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 05:30:19 -0800 (PST) Message-ID: <65c9cd0a-ef4e-5d38-3b15-0126b1eb7a7f@linaro.org> Date: Tue, 29 Nov 2022 14:30:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0 Content-Language: en-US To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org, agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski@linaro.org, me@iskren.info, Bjorn Andersson References: <20221128171215.1768745-1-bhupesh.sharma@linaro.org> From: Konrad Dybcio In-Reply-To: <20221128171215.1768745-1-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28.11.2022 18:12, Bhupesh Sharma wrote: > qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart. > Add the debug uart node in sm6115 dtsi file. > > Cc: Bjorn Andersson > Cc: Rob Herring > Signed-off-by: Bhupesh Sharma > --- > - Based on linux-next. > > arch/arm64/boot/dts/qcom/sm6115.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > index 0340ed21be05..e4a2440ce544 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > @@ -649,6 +649,26 @@ ufs_mem_phy_lanes: phy@4807400 { > }; > }; > > + qupv3_id_0: geniqup@4ac0000 { > + compatible = "qcom,geni-se-qup"; > + reg = <0x4ac0000 0x2000>; Please pad address to 8 hex digits, same below. Konrad > + clock-names = "m-ahb", "s-ahb"; > + clocks = <&gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, > + <&gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + uart4: serial@4a90000 { > + compatible = "qcom,geni-debug-uart"; > + reg = <0x4a90000 0x4000>; > + clock-names = "se"; > + clocks = <&gcc GCC_QUPV3_WRAP0_S4_CLK>; > + interrupts = ; > + status = "disabled"; > + }; > + }; > + > usb_1: usb@4ef8800 { > compatible = "qcom,sm6115-dwc3", "qcom,dwc3"; > reg = <0x04ef8800 0x400>;