From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 981321509AF; Mon, 30 Sep 2024 07:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727680574; cv=none; b=jrfADPi1IKJRX65UouCeAUHZUskrqSehnQGR7zBpWpZ3kP3SQdzLiGQAVnfL7k4iMYeSj6BeP05Y4s2xUkiiZeRbuNDWXc0g6bb2yKijHDikT9PaY6xJIP2dr0n7FbaWoaKHOCcZeMYhs3Kqb7mfUzzl4luGEZl1JXdXRDEFb00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727680574; c=relaxed/simple; bh=buyP+ms/pBMokoBz5muUX+XZQXW5KuXVs7Je/yX434A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TWQ/ZClqHWyO7N3YHYPR119JMso9snq0VcwlhK+cTe82/tddRlVXdU3GJ75SBnmwwT4w08NqoRUtumM4p4k/TNfBDKz0trN0Ra6l+aKKSpi7BUB+Dp2QOmwfNFkpG/oxD3m458SUjkKhxZA5ezCEC213thy/xuVqhXRFgRn0GsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O+5hOCaM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O+5hOCaM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67B29C4CEC7; Mon, 30 Sep 2024 07:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727680574; bh=buyP+ms/pBMokoBz5muUX+XZQXW5KuXVs7Je/yX434A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O+5hOCaM2MMVX4bacN9kwqptVtgFTvt18wfF9O6bbkMcAqYqSRJfrI2zP42GwBAXN eP+W5kx+YX2ZOlBMknzlG9GsMZ7ppVyeaaqUBLjfaI1p3rMVPZJKTYvZiu0QFpqYay YAXGAEshazVOIiceUJmSWq+zXiGIGCZxuBkYAVpP6fJjDPRrwl0hlhwSe9UjMWe9Nr c0OK5Tb6nAYA7OBM+gMZ0S7QQsBbg8teQfKYCOYFSLZL6azzgAQvkQ56OC44aG5ISx g75zG45AGcSLsrnk1KzwhR4x08m+wW4CYjhld32u203pF5onj9KOqEWoHqbmclAaFq fJ6CxKonQQtfg== Message-ID: <65e5796a-8b8d-44f0-aef4-e420083b9d52@kernel.org> Date: Mon, 30 Sep 2024 09:16:08 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding To: Depeng Shao , Vladimir Zapolskiy , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-8-quic_depengs@quicinc.com> <9ed92660-5f42-4a1a-9261-b8800133972a@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 25/09/2024 17:13, Depeng Shao wrote: > Hi Vladimir, > > On 9/6/2024 11:56 PM, Vladimir Zapolskiy wrote: > >>> +            compatible = "qcom,sm8550-camss"; >>> + >>> +            reg = <0 0x0acb7000 0 0xd00>, >>> +                  <0 0x0acb9000 0 0xd00>, >>> +                  <0 0x0acbb000 0 0xd00>, >>> +                  <0 0x0acca000 0 0xa00>, >>> +                  <0 0x0acce000 0 0xa00>, >>> +                  <0 0x0acb6000 0 0x1000>, >>> +                  <0 0x0ace4000 0 0x2000>, >>> +                  <0 0x0ace6000 0 0x2000>, >>> +                  <0 0x0ace8000 0 0x2000>, >>> +                  <0 0x0acea000 0 0x2000>, >>> +                  <0 0x0acec000 0 0x2000>, >>> +                  <0 0x0acee000 0 0x2000>, >>> +                  <0 0x0acf0000 0 0x2000>, >>> +                  <0 0x0acf2000 0 0x2000>, >>> +                  <0 0x0ac62000 0 0xf000>, >>> +                  <0 0x0ac71000 0 0xf000>, >>> +                  <0 0x0ac80000 0 0xf000>, >>> +                  <0 0x0accb000 0 0x2800>, >>> +                  <0 0x0accf000 0 0x2800>; >> >> Please sort the list above in numerical order, this will change positions >> of "vfe_lite0", "vfe_lite1" etc. >> >> Another note, since it's not possible to map less than a page, so I believe >> it might make sense to align all sizes to 0x1000. >> > > Sure, I previously sorted by the alphabetical order of reg_name. > I will update it based on your suggestion. And will also make sure the > align all sizes to 0x1000. If I understood correctly, you want to change the order from existing devices, so no. You are supposed to keep the same order, as much as possible. Best regards, Krzysztof