From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.Li@nxp.com>,
krzysztof.kozlowski+dt@linaro.org, peng.fan@nxp.com,
vkoul@kernel.org
Cc: devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
imx@lists.linux.dev, joy.zou@nxp.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
shenwei.wang@nxp.com
Subject: Re: [PATCH v2 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string
Date: Tue, 30 May 2023 15:08:48 +0200 [thread overview]
Message-ID: <65e7b6df-b83b-2d7c-5093-f5822050827a@linaro.org> (raw)
In-Reply-To: <20230529200453.1423796-13-Frank.Li@nxp.com>
On 29/05/2023 22:04, Frank Li wrote:
> Extend Freescale eDMA driver bindings to support eDMA3 IP blocks in
> i.MX8QM and i.MX8QXP SoCs. In i.MX93, both eDMA3 and eDMA4 are now.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> .../devicetree/bindings/dma/fsl,edma.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 5fd8fc604261..eed12687b0c9 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,6 +21,10 @@ properties:
> - enum:
> - fsl,vf610-edma
> - fsl,imx7ulp-edma
> + - fsl,imx8qm-edma
> + - fsl,imx8qm-adma
> + - fsl,imx93-edma3
> + - fsl,imx93-edma4
What are these last two? What is "3" and "4"?
> - items:
> - const: fsl,ls1028a-edma
> - const: fsl,vf610-edma
> @@ -101,6 +105,22 @@ allOf:
> reg:
> maxItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + anyOf:
> + - const: fsl,imx8qm-edma
> + - const: fsl,imx8qm-adma
> + - const: fsl,imx93-edma3
> + - const: fsl,imx93-edma4
> + then:
> + properties:
> + reg:
> + maxItems: 1
> + interrupts:
> + maxItems: 64
That's odd. What about the names? What about minItems? Anyway, this
wasn't tested - you will have failures with dtbs_check.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-30 13:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 20:04 [PATCH v2 00/12] dmaengine: edma: add freescale edma v3 support Frank Li
2023-05-29 20:04 ` [PATCH v2 01/12] dmaengine: fsl-edma: clean up EXPORT_SYMBOL_GPL in fsl-edma-common.c Frank Li
2023-05-31 6:45 ` Peng Fan
2023-05-29 20:04 ` [PATCH v2 02/12] dmaengine: fsl-edma: clean up fsl_edma_irq_exit() Frank Li
2023-05-31 6:46 ` Peng Fan
2023-05-29 20:04 ` [PATCH v2 03/12] dmaengine: fsl-edma: transition from bool fields to bitmask flags in drvdata Frank Li
2023-05-31 6:47 ` Peng Fan
2023-05-29 20:04 ` [PATCH v2 04/12] dmaengine: fsl-edma: remove v3 from enum edma_version Frank Li
2023-05-31 6:50 ` Peng Fan
2023-05-31 12:50 ` Frank Li
2023-05-29 20:04 ` [PATCH v2 05/12] dmaengine: fsl-edma: move common IRQ handler to common.c Frank Li
2023-05-29 20:04 ` [PATCH v2 06/12] dmaengine: fsl-edma: simply ATTR_DSIZE and ATTR_SSIZE by using ffs() Frank Li
2023-05-29 20:04 ` [PATCH v2 07/12] dmaengine: fsl-edma: refactor using devm_clk_get_enabled Frank Li
2023-05-29 20:04 ` [PATCH v2 08/12] dmaengine: fsl-edma: move clearing of register interrupt into setup_irq function Frank Li
2023-05-29 20:04 ` [PATCH v2 09/12] dmaengine: fsl-edma: refactor chan_name setup and safety Frank Li
2023-05-29 20:04 ` [PATCH v2 10/12] dmaengine: fsl-edma: move tcd into struct fsl_dma_chan Frank Li
2023-05-29 20:04 ` [PATCH v2 11/12] dmaengine: fsl-edma: integrate v3 support Frank Li
2023-05-29 20:04 ` [PATCH v2 12/12] dt-bindings: fsl-dma: fsl-edma: add edma3 compatible string Frank Li
2023-05-30 13:08 ` Krzysztof Kozlowski [this message]
2023-05-30 13:57 ` Frank Li
2023-05-30 14:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e7b6df-b83b-2d7c-5093-f5822050827a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).