devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Nikola Milosavljević" <mnidza@outlook.com>,
	"Peter Geis" <pgwipeout@gmail.com>,
	"Nicolas Chauvet" <kwizart@gmail.com>,
	"Viresh Kumar" <vireshk@kernel.org>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Matt Merhar" <mattmerhar@protonmail.com>,
	"Paul Fertser" <fercerpav@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-tegra <linux-tegra@vger.kernel.org>,
	DTML <devicetree@vger.kernel.org>,
	"Linux PM" <linux-pm@vger.kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 13/14] soc/tegra: pmc: Add core power domain
Date: Mon, 24 May 2021 23:25:07 +0300	[thread overview]
Message-ID: <65f65cb9-a25f-9c2c-2902-7e1776d66661@gmail.com> (raw)
In-Reply-To: <CAPDyKFrto2cosX3Ben_QWCYVqgeoF1Yv=8gEx4Y86WNyjeHvdg@mail.gmail.com>

24.05.2021 20:04, Ulf Hansson пишет:
>> +static void tegra_pmc_sync_state(struct device *dev)
>> +{
>> +       int err;
>> +
>> +       pmc->core_domain_state_synced = true;
>> +
>> +       /* this is a no-op if core regulator isn't used */
>> +       mutex_lock(&pmc->powergates_lock);
>> +       err = dev_pm_opp_sync_regulators(dev);
>> +       mutex_unlock(&pmc->powergates_lock);
>> +
>> +       if (err)
>> +               dev_err(dev, "failed to sync regulators: %d\n", err);
>> +}
>> +
> Nitpick.
> 
> Would you mind splitting the "sync_state" thingy out into a separate
> patch on top of $subject patch?
> 
> I think it would be nice, especially since it shares a function via
> include/soc/tegra/common.h - that would make it clear to what part
> that belongs to.
> 

I'll split it in v3. Thank you for the review.

  parent reply	other threads:[~2021-05-24 20:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 23:13 [PATCH v2 00/14] NVIDIA Tegra memory and power management changes for 5.14 Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 01/14] regulator: core: Add regulator_sync_voltage_rdev() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 02/14] regulator: core: Detach coupled regulator before coupling count is dropped Dmitry Osipenko
2021-05-24 10:20   ` Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 03/14] soc/tegra: regulators: Bump voltages on system reboot Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 04/14] soc/tegra: Add stub for soc_is_tegra() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 05/14] soc/tegra: Add devm_tegra_core_dev_init_opp_table() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 06/14] soc/tegra: fuse: Add stubs needed for compile-testing Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 07/14] clk: tegra: " Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 08/14] memory: tegra: Fix compilation warnings on 64bit platforms Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 09/14] memory: tegra: Enable compile testing for all drivers Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 10/14] memory: tegra20-emc: Use devm_tegra_core_dev_init_opp_table() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 11/14] memory: tegra30-emc: " Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 12/14] dt-bindings: soc: tegra-pmc: Document core power domain Dmitry Osipenko
2021-05-24 17:02   ` Ulf Hansson
2021-05-23 23:13 ` [PATCH v2 13/14] soc/tegra: pmc: Add " Dmitry Osipenko
2021-05-24 17:04   ` Ulf Hansson
2021-05-24 20:23     ` Dmitry Osipenko
2021-05-31 13:17       ` Ulf Hansson
2021-05-31 20:07         ` Dmitry Osipenko
2021-06-01 10:19           ` Ulf Hansson
2021-06-01 15:48             ` Dmitry Osipenko
2021-05-24 20:25     ` Dmitry Osipenko [this message]
2021-05-23 23:13 ` [PATCH v2 14/14] soc/tegra: regulators: Support core domain state syncing Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65f65cb9-a25f-9c2c-2902-7e1776d66661@gmail.com \
    --to=digetx@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fercerpav@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=kwizart@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mattmerhar@protonmail.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=mnidza@outlook.com \
    --cc=mperttunen@nvidia.com \
    --cc=nathan@kernel.org \
    --cc=pgwipeout@gmail.com \
    --cc=sboyd@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).