From: Stephen Boyd <sboyd@kernel.org>
To: Abel Vesa <abelvesa@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, Lee Jones <lee@kernel.org>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1 04/20] ARM: imx6q: use of_clk_get_by_name() instead of_clk_get() to get ptp clock
Date: Fri, 13 Jan 2023 16:15:53 -0800 [thread overview]
Message-ID: <66131cea80d3a8a33e559f84fb808c6b.sboyd@kernel.org> (raw)
In-Reply-To: <20230113142718.3038265-5-o.rempel@pengutronix.de>
Quoting Oleksij Rempel (2023-01-13 06:27:02)
> It is not clear from the code what clock should be taken. So, make sure it
> is readable and no other clock will be taken by accident.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/mach-imx/mach-imx6q.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 7f6200925752..4885d3dfcf7f 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -98,7 +98,7 @@ static void __init imx6q_1588_init(void)
> if (!IS_ERR(fec_enet_ref))
> goto put_node;
>
> - ptp_clk = of_clk_get(np, 2);
> + ptp_clk = of_clk_get_by_name(np, "ptp");
The 'clocks' property in DTS should not be reordered. Order matters in
the binding. This patch makes the code do a string comparison (or a
few?) in the name of readability. Perhaps make a #define for '2' like
CLOCKS_PTP_INDEX, or just don't change it because it ain't broke.
next prev parent reply other threads:[~2023-01-14 0:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 14:26 [PATCH v1 00/20] ARM: imx: make Ethernet refclock configurable Oleksij Rempel
2023-01-13 14:26 ` [PATCH v1 01/20] clk: imx: add clk-gpr-mux driver Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 02/20] clk: imx6q: add ethernet refclock mux support Oleksij Rempel
2023-01-13 22:56 ` kernel test robot
2023-01-15 6:25 ` kernel test robot
2023-01-13 14:27 ` [PATCH v1 03/20] ARM: imx6q: skip ethernet refclock reconfiguration if enet_clk_ref is present Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 04/20] ARM: imx6q: use of_clk_get_by_name() instead of_clk_get() to get ptp clock Oleksij Rempel
2023-01-14 0:15 ` Stephen Boyd [this message]
2023-01-13 14:27 ` [PATCH v1 05/20] ARM: dts: imx6qdl: use enet_clk_ref instead of enet_out for the FEC node Oleksij Rempel
2023-01-16 1:01 ` Peng Fan
2023-01-16 5:26 ` Oleksij Rempel
2023-01-17 1:45 ` Peng Fan
2023-01-13 14:27 ` [PATCH v1 06/20] ARM: dts: imx6dl-lanmcu: configure ethernet reference clock parent Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 07/20] ARM: dts: imx6dl-alti6p: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 08/20] ARM: dts: imx6dl-plybas: " Oleksij Rempel
2023-01-14 11:39 ` Fabio Estevam
2023-01-13 14:27 ` [PATCH v1 09/20] ARM: dts: imx6dl-plym2m: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 10/20] ARM: dts: imx6dl-prtmvt: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 11/20] ARM: dts: imx6dl-victgo: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 12/20] ARM: dts: imx6q-prtwd2: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 13/20] ARM: dts: imx6qdl-skov-cpu: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 14/20] ARM: dts: imx6dl-eckelmann-ci4x10: " Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 15/20] clk: imx: add imx_obtain_fixed_of_clock() Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 16/20] clk: imx6ul: fix enet1 gate configuration Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 17/20] clk: imx6ul: add ethernet refclock mux support Oleksij Rempel
2023-01-13 14:48 ` Lee Jones
2023-01-14 1:07 ` kernel test robot
2023-01-15 8:46 ` kernel test robot
2023-01-13 14:27 ` [PATCH v1 18/20] ARM: dts: imx6ul: set enet_clk_ref to CLK_ENETx_REF_SEL Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 19/20] ARM: mach-imx: imx6ul: remove not optional ethernet refclock overwrite Oleksij Rempel
2023-01-13 14:27 ` [PATCH v1 20/20] ARM: dts: imx6ul-prti6g: configure ethernet reference clock parent Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66131cea80d3a8a33e559f84fb808c6b.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=abelvesa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).