From: Rohit Agarwal <quic_rohiagar@quicinc.com>
To: <andy.shevchenko@gmail.com>
Cc: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <linus.walleij@linaro.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<richardcochran@gmail.com>, <manivannan.sadhasivam@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver
Date: Wed, 26 Apr 2023 20:48:29 +0530 [thread overview]
Message-ID: <66158251-6934-a07f-4b82-4deaa76fa482@quicinc.com> (raw)
In-Reply-To: <ZEk9lySMZcrRZYwX@surfacebook>
On 4/26/2023 8:34 PM, andy.shevchenko@gmail.com wrote:
> Mon, Apr 24, 2023 at 02:33:50PM +0530, Rohit Agarwal kirjoitti:
>> Add initial Qualcomm SDX75 pinctrl driver to support pin configuration
>> with pinctrl framework for SDX75 SoC.
>> While at it, reordering the SDX65 entry.
> ...
>
>> +#define FUNCTION(fname) \
>> + [msm_mux_##fname] = { \
>> + .name = #fname, \
>> + .groups = fname##_groups, \
>> + .ngroups = ARRAY_SIZE(fname##_groups), \
>> + }
> PINCTRL_PINFUNCTION() ?
Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"?
>
> ...
>
>> +static const struct of_device_id sdx75_pinctrl_of_match[] = {
>> + {.compatible = "qcom,sdx75-tlmm", .data = &sdx75_pinctrl}, {},
> One entry per line.
> And drop comma in the terminator one.
>
>> +};
> No MODULE_DEVICE_TABLE()?
Sure Will update both.
Thanks,
Rohit.
>
next prev parent reply other threads:[~2023-04-26 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 9:03 [PATCH v4 0/2] Add pinctrl support for SDX75 Rohit Agarwal
2023-04-24 9:03 ` [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add SDX75 pinctrl devicetree compatible Rohit Agarwal
2023-04-24 9:45 ` Krzysztof Kozlowski
2023-04-24 9:03 ` [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver Rohit Agarwal
2023-04-26 15:04 ` andy.shevchenko
2023-04-26 15:18 ` Rohit Agarwal [this message]
2023-04-26 16:42 ` Andy Shevchenko
2023-04-27 8:53 ` Rohit Agarwal
2023-04-27 10:54 ` Andy Shevchenko
2023-04-27 11:07 ` Rohit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66158251-6934-a07f-4b82-4deaa76fa482@quicinc.com \
--to=quic_rohiagar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox