From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback Date: Thu, 7 Dec 2017 12:50:50 -0500 Message-ID: <661cbe4d-ea33-3e84-b5f2-ab6517cbb135@codeaurora.org> References: <1512493493-6464-1-git-send-email-okaya@codeaurora.org> <1512493493-6464-5-git-send-email-okaya@codeaurora.org> <20171207141029.575c0a03@karo-electronics.de> <20171207162036.6a71a4f5@karo-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20171207162036.6a71a4f5@karo-electronics.de> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?Q?Lothar_Wa=c3=9fmann?= Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, timur@codeaurora.org, open list , linux-acpi@vger.kernel.org, Rob Herring , dmaengine@vger.kernel.org, Frank Rowand , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 12/7/2017 10:20 AM, Lothar Waßmann wrote: > Hi, > > On Thu, 7 Dec 2017 09:45:31 -0500 Sinan Kaya wrote: >> On 12/7/2017 8:10 AM, Lothar Waßmann wrote: >>>> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, >>>> + struct device *dev) >>> Shouldn't this be 'const void *of_fwnode_get_match_data >> >> OF keeps the driver data as a (const void*) internally. ACPI keeps the >> driver data as kernel_ulong_t in struct acpi_device_id. >> >> I tried to find the middle ground here by converting output to void* >> but not keeping const. >> > It should be no problem to cast a (const void *) to an unsigned long > data type (without const qualifier). > It is the other way around. If I change this API to return a a (const void*), the device_get_match_data() function need to return a (const void *). While implementing the ACPI piece, I have to convert an unsigned long to (const void *) in ACPI code so that the APIs are compatible. > > Lothar Waßmann > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.