Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller

[Mark Kettenis <mark.kettenis@xs4all.nl>]

Hi Emmanuel,

I think the following bit in your proposed binding is wrong:

+- #thermal-sensor-cells : Depend on the SoC
+   For H3 should be 0
+   For H5 should be 1
+   For A64 should be 2
+   See ./thermal.txt for a description.

I think what you're trying to say here is that H3 has a single sensor
and that H5 and A64 have more sensors.  But even though the number of
sensors is different for H5 and A64 (two for H3, three for A64) you
need only a single cell to describe which sensor to read.  So
#thermal-sensors-cells should be 1 for both H5 and A64.

As far as I can see this proposed binding is compatible with the
OpenBSD's sxitemp(4) driver.  That driver also supports the R40 with
"allwinner,sun8i-r40-ths" as the compatible string.  The R40 has two
sensors so #thermal-sensor-cells should be 1 for this SoC as well.

Cheers,

Mark