From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] rcar-csi2: add R8A77980 support
Date: Wed, 19 Sep 2018 21:44:53 +0300 [thread overview]
Message-ID: <662a85e2-a26a-515c-2e0c-05df9f7570d8@cogentembedded.com> (raw)
In-Reply-To: <20180917111748.GT18450@bigcity.dyn.berto.se>
Hello!
On 09/17/2018 02:17 PM, Niklas Söderlund wrote:
>>>> Add the R-Car V3H (AKA R8A77980) SoC support to the R-Car CSI2 driver.
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> It looks good but before I add my tag I would like to know if you tested
>>> this on a V3H?
>>
>> No, have not tested the upstream patch, seemed too cumbersome (we did
>> test the BSP patch AFAIK).
>
> Did you find time to test this change? I think it looks good but I would
Unfortunately, no.
> feel a lot better about this change if I knew it was tested :-) More
> often then not have we shaken a bug out of the rcar-{csi2,vin} tree by
> adding support for a new SoC.
>
> Also if you for some reason need to resend this series could you split
> the DT documentation and driver changes in two separate patches?
OK.
>>> In the past extending the R-Car CSI-2 receiver to a new
>>> SoC always caught some new corner case :-)
>>>
>>> I don't have access to a V3H myself otherwise I would of course test it
>>> myself.
>>
>> CSI-2 on the Condor board is connected to a pair of MAX9286 GMSL de-serializers
>> which are connected to 4 (composite?) connectors... There's supposed to be sensor
>> chip on the other side, AFAIK...
>
> There is experimental patches which are tested on V3M that uses the
> MAX9286 GMSL setup if you feel brave and want to try and extend them to
> cover V3H ;-P
Wouldn't hurt having them. :-)
MBR, Sergei
next prev parent reply other threads:[~2018-09-19 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 16:56 [PATCH] rcar-csi2: add R8A77980 support Sergei Shtylyov
2018-08-06 18:02 ` Niklas Söderlund
2018-08-06 18:24 ` Sergei Shtylyov
2018-09-17 11:17 ` Niklas Söderlund
2018-09-19 18:44 ` Sergei Shtylyov [this message]
2018-09-19 21:43 ` Niklas Söderlund
2018-08-20 22:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=662a85e2-a26a-515c-2e0c-05df9f7570d8@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).