devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Michael Hennerich <michael.hennerich@analog.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v4 1/2] iio:adc:ad7476: Handle the different regulators used by various parts.
Date: Sun, 25 Apr 2021 18:39:03 +0200	[thread overview]
Message-ID: <662ed93c-7567-7acb-15c4-5526af80209e@metafoo.de> (raw)
In-Reply-To: <20210425163154.73209-2-jic23@kernel.org>

On 4/25/21 6:31 PM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Not all of the parts supported by this driver use single supply.
> Hence we add chip_info fields to say what additional supplies exist
> and in the case of vref, ensure that is used for the reference voltage
> rather than vcc.
>
> One corner case is the ad7091r which has an internal reference that
> can be over-driven by an external reference connected on the vref pin.
> To handle that force_ext_vref is introduced and set if an optional
> vref regulator is present.
>
> Tested using really simple QEMU model and some fixed regulators.
>
> The devm_add_action_or_reset() callback is changed to take the
> regulator as it's parameter so we can use one callback for all the
> different regulators without having to store pointers to them in
> the iio_priv() structure.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
> Reported-by: kernel test robot <lkp@intel.com>

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>


  reply	other threads:[~2021-04-25 16:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25 16:31 [PATCH v4 0/2] iio:adc:ad7476: Regulator support and binding doc Jonathan Cameron
2021-04-25 16:31 ` [PATCH v4 1/2] iio:adc:ad7476: Handle the different regulators used by various parts Jonathan Cameron
2021-04-25 16:39   ` Lars-Peter Clausen [this message]
2021-04-25 16:31 ` [PATCH v4 2/2] dt-bindings:iio:adc:adi,ad7476: Add missing binding document Jonathan Cameron
2021-04-27 17:00 ` [PATCH v4 0/2] iio:adc:ad7476: Regulator support and binding doc Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=662ed93c-7567-7acb-15c4-5526af80209e@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=michael.hennerich@analog.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).