From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Rajendra Nayak <rnayak@ti.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
tony@atomide.com, nm@ti.com, bcousson@baylibre.com
Subject: Re: [PATCH v2 3/4] ARM: OMAP2+: Add machine entry for dra72x devices
Date: Wed, 23 Apr 2014 11:51:54 +0200 [thread overview]
Message-ID: <66310471.kybX1mlztt@wuerfel> (raw)
In-Reply-To: <1398243775-4145-4-git-send-email-rnayak@ti.com>
On Wednesday 23 April 2014 14:32:54 Rajendra Nayak wrote:
>
> #ifdef CONFIG_SOC_DRA7XX
> -static const char *dra7xx_boards_compat[] __initdata = {
> +static const char *dra74x_boards_compat[] __initconst = {
> + "ti,dra74x",
> "ti,dra7xx",
> "ti,dra7",
> NULL,
> };
>
> -DT_MACHINE_START(DRA7XX_DT, "Generic DRA7XX (Flattened Device Tree)")
> +DT_MACHINE_START(DRA74X_DT, "Generic DRA74X (Flattened Device Tree)")
> .reserve = omap_reserve,
> .smp = smp_ops(omap4_smp_ops),
> .map_io = omap5_map_io,
> @@ -255,7 +256,26 @@ DT_MACHINE_START(DRA7XX_DT, "Generic DRA7XX (Flattened Device Tree)")
> .init_irq = omap_gic_of_init,
> .init_machine = omap_generic_init,
> .init_time = omap5_realtime_timer_init,
> - .dt_compat = dra7xx_boards_compat,
> + .dt_compat = dra74x_boards_compat,
> + .restart = omap44xx_restart,
> +MACHINE_END
> +
> +static const char *dra72x_boards_compat[] __initconst = {
> + "ti,dra72x",
> + "ti,dra7xx",
> + "ti,dra7",
> + NULL,
> +};
Now you have two lists that both match "ti,dra7xx" and "ti,dra7", which will
cause problems if you have a new machine that doesn't match the more specific
strings.
Note that we intentionally don't allow wildcards in compatible strings
to avoid this situation.
Please remove all strings with an "x" in them from the dts files and from
the source, and make sure you have no duplication between the lists.
Arnd
next prev parent reply other threads:[~2014-04-23 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 9:02 [PATCH v2 0/4] ARM: DRA7: Add support for DRA72x devices Rajendra Nayak
2014-04-23 9:02 ` [PATCH v2 1/4] ARM: dts: dra7-evm: Remove the wrong and undocumented compatible Rajendra Nayak
2014-04-23 9:02 ` [PATCH v2 2/4] ARM: dts: Add support for DRA72x family of devices Rajendra Nayak
2014-04-23 9:02 ` [PATCH v2 3/4] ARM: OMAP2+: Add machine entry for dra72x devices Rajendra Nayak
2014-04-23 9:51 ` Arnd Bergmann [this message]
2014-04-23 11:13 ` Rajendra Nayak
2014-04-23 9:02 ` [PATCH v2 4/4] ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x() varients Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66310471.kybX1mlztt@wuerfel \
--to=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox