Re: [PATCH v6 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/03/2026 14:28, Sirat wrote:
> On Fri, Mar 20, 2026 at 6:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 19/03/2026 20:07, Siratul Islam wrote:
>>>
>>>  properties:
>>>    compatible:
>>> -    const: st,vl53l0x
>>> +    enum:
>>> +      - st,vl53l0x
>>> +      - st,vl53l1x
>>>
>>>    reg:
>>>      maxItems: 1
>>> @@ -21,12 +24,17 @@ properties:
>>>
>>>    reset-gpios:
>>>      maxItems: 1
>>> +    description:
>>> +      Phandle to the XSHUT GPIO. Used for hardware reset.
>>>
>>> -  vdd-supply: true
>>> +  vdd-supply:
>>> +    description:
>>> +      Phandle to the vdd input voltage. This is physically required for operation.
>>
>> Drop the description. Schema tells that.
>>
>>>
>>>  required:
>>>    - compatible
>>>    - reg
>>> +  - vdd-supply
>>
>> That's an ABI break and nothing in commit msg explains why. You need
>> rationale for this, but most likely everything was working fine before,
>> so supply should not be required.
>>
> The vdd-supply is practically required by both the drivers depending
> on this binding,
> But the original driver author did not specify the requirement on the binding.
> The driver works with or without the binding (it falls back to a dummy
> regulator when not specified),
> but specifying it makes the intent clear.

"That's an ABI break and nothing in commit msg explains why. "

Please don't ask me to quote it third time... See also writing-bindings
doc. You must provide rationale for ABI changes.

Best regards,
Krzysztof