From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mainlining.org (mail.mainlining.org [5.75.144.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3E0366823; Tue, 10 Mar 2026 13:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.75.144.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148333; cv=none; b=faZQuEAcbErCqeEkni+lePBd2buy2WMi1C2IYVPaYIdArPCOgalXjxycKpsO+8C3mCJX9iHg7pvzz4iXign2zQ1NKkXj9+Zh6SuSTwIqGQcNpQ2jO2oEBds2KUgT4MydmxyemYlU9Uo/JZ3FCgGaluHhSiIopFlh3dMCouMfXn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148333; c=relaxed/simple; bh=c/Vg1Ik3Z2a4pYD3C51ivOFAkNwf8RUtiEejYJQFtfI=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=GeYiM0NIr8gVcp5d+oRL6hF5v4dTFAFuVG2dBGNkOzrE3Jn2DdC2a/Xjnl4qxbbAA4/dWE2f1gsk2oXWgIbpcXsM1/zYb/pwSyHpHXsLtBwIlT4Zzz0ykbxT2B5bFQf7e5Uf5lAen4Bymz7N4yLRiCyFf1oy3dekWTyQx9rJ7i4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org; spf=pass smtp.mailfrom=mainlining.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=bSn356jE; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b=/OmuMjaG; arc=none smtp.client-ip=5.75.144.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mainlining.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mainlining.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="bSn356jE"; dkim=permerror (0-bit key) header.d=mainlining.org header.i=@mainlining.org header.b="/OmuMjaG" DKIM-Signature: v=1; a=rsa-sha256; s=202507r; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Subject:To:From:Date; t=1773148319; bh=kpIj4TJK9BZX6D+F/wIT3mH 8xp6/3sJ/cdxzzaBC2tY=; b=bSn356jERy+OaboYAU8+9fk4ze/jaQJWMZGHGS9v6prv29yhsd JL8ANVpc5qLTpmzGg6gKzhHQAJrRFrB7XwY2ZSh0/xjHIV4E5DpaDfsdQMqceL2rK38FMGo0XnE mN5mv4XEWFU/T+pOVMAy7S16pCNgn5jGgLV6kRUpAtx03sy3vCfr3qgwaGh2PuA8/GEJOY8kmum xjLKE0j9Vs/7qXZD+RO4+Vi0MqBBpuLXRoic7p9UliYCQtvq4Py1SuPHbV4Ka+L6JH5/jO6dDR2 a4XQ4ZyHaofeBiAPl/NmJH/ztw63U92jVWifrphwJbjd2B4/dRz28C6v77MJh0M9hbg==; DKIM-Signature: v=1; a=ed25519-sha256; s=202507e; d=mainlining.org; c=relaxed/relaxed; h=Message-ID:Subject:To:From:Date; t=1773148319; bh=kpIj4TJK9BZX6D+F/wIT3mH 8xp6/3sJ/cdxzzaBC2tY=; b=/OmuMjaGRPH1uNIu+DbsXCbtdUQDiBvwmcQNYDujzXWAgt3n+7 Ym1Ic9uo3nxuf39WthJStRvjcKSp40BClkDQ==; Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 10 Mar 2026 14:11:59 +0100 From: barnabas.czeman@mainlining.org To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, phone-devel@vger.kernel.org Subject: Re: [PATCH 1/5] arm64: dts: qcom: msm8917-xiaomi-riva: Commonize for Redmi 4A and GO In-Reply-To: <2255b753-4d40-4e49-a89c-22ee939c51d1@oss.qualcomm.com> References: <20260305-riva-common-v1-0-436f1f4b7399@mainlining.org> <20260305-riva-common-v1-1-436f1f4b7399@mainlining.org> <2255b753-4d40-4e49-a89c-22ee939c51d1@oss.qualcomm.com> Message-ID: <6665244d82ee8776826a7f6a4e64af99@mainlining.org> X-Sender: barnabas.czeman@mainlining.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-03-10 14:04, Konrad Dybcio wrote: > On 3/10/26 1:57 PM, barnabas.czeman@mainlining.org wrote: >> On 2026-03-09 13:55, Konrad Dybcio wrote: >>> On 3/5/26 6:28 PM, Barnabás Czémán wrote: >>>> Redmi 5A is very similar for Redmi 4A (rolex) and Redmi GO (tiare), >>>> it can be commonized for avoid unnecessary code duplications. >>>> >>>> Signed-off-by: Barnabás Czémán >>>> --- >>> >>> Could you please try adding the following to your gitconfig: >>> >>> [diff] >>>         renameLimit = 999999 >>>         algorithm = histogram # or 'copies' >>>         renames = copies >>> >>> and see if this generates a shorter diff? >>> >>> Konrad >> One more question should i rename msm8917-xiaomi-riva-common to >> msm8917-wingtech-common, >> they are wingtech devices. Which naming is preferred? > > I think xiaomi-riva is easier for people to associate with a phone > they may have in their drawer than wingtech-s88503 What about renaming just the common part to msm8917-wingtech-common? > > Konrad