From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andre Werner <werneazc@gmail.com>,
jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Andre Werner <andre.werner@systec-electronic.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001
Date: Sun, 16 Jul 2023 18:32:55 +0200 [thread overview]
Message-ID: <669d064e-4873-eb0f-6996-214663144a29@kernel.org> (raw)
In-Reply-To: <20230714064336.28371-1-andre.werner@systec-electronic.com>
On 14/07/2023 08:43, Andre Werner wrote:
> This is the initial description.
>
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.
Didn't you get this comment already? If so, why you decided to ignore it?
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ba2bfb547909..5a5de3f6cd37 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -320,6 +320,8 @@ properties:
> # Rohm DH2228FV
> - rohm,dh2228fv
> # S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
> + - renesas,hs3001
> + # Renesas HS300[1,2,3,4] Temperature and Relative Humidity Sensors
Wrong placement of comment.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-16 16:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 6:43 [PATCH v2 1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001 Andre Werner
2023-07-14 6:43 ` [PATCH v2 2/2] hwmon: (hs3001) Add driver for Renesas HS3001 Andre Werner
2023-07-14 22:29 ` Guenter Roeck
2023-07-14 21:09 ` [PATCH v2 1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001 Rob Herring
2023-07-16 16:32 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-16 15:05 Andre Werner
2023-07-16 16:33 ` Krzysztof Kozlowski
2023-07-16 17:05 ` Guenter Roeck
2023-07-18 7:01 Andre Werner
2023-07-18 7:21 ` Krzysztof Kozlowski
2023-07-18 7:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=669d064e-4873-eb0f-6996-214663144a29@kernel.org \
--to=krzk@kernel.org \
--cc=andre.werner@systec-electronic.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=werneazc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).