Devicetree
 help / color / mirror / Atom feed
From: Pavel Modilaynen <pavel.modilaynen@axis.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: RE: [PATCH] dtc: Use pkg-config to locate libyaml
Date: Fri, 8 Nov 2019 09:17:17 +0000	[thread overview]
Message-ID: <66bc78ec83c940cd92932221a0c5c387@XBOX07.axis.com> (raw)
In-Reply-To: <CAL_JsqK-NqxuNKGv5s68DMrxpnHdU-M-vKkP4pTgdfrYRo=09A@mail.gmail.com>

> From: Rob Herring <robh+dt@kernel.org>

> > Using Makefile's wildcard with absolute path to detect the presence of
> > libyaml results in false-positive detection when cross-compiling e.g.
> > in yocto environment.
> 
> As this is a host tool, it's not really about cross-compiling, but sandboxing the
> host env? IOW, I cross-compile all the time and don't have an issue.

Yes, you are correct, this is to address sandboxing, too late to correct?

> 
> > Use pkg-config to locate libyaml to address this scenario.
> 
> The reason I didn't use pkg-config in the first place is it adds another
> dependency. AIUI, it's only needed for gconfig/xconfig which are probably
> not widely used especially for CI. Looks like objtool needs it too, but that's
> x86 only though arm64 support is being worked on. So I guess it is pretty
> much becoming a requirement.

Exactly, the patch was inspired by usage of pkg-config in that shell scripts 
assuming that it's more correct way to handle libyaml dependency...
I see it also used for building tools.

Should I maybe add new patch to fallback to wildcard when pkg-config is not found?

> 
> So I've applied it. I added suppressing stderr in case pkg-config isn't present.

Thank you!

Pavel

      reply	other threads:[~2019-11-08  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12 11:52 [PATCH] dtc: Use pkg-config to locate libyaml Pavel Modilaynen
2019-11-04 17:27 ` Rob Herring
2019-11-08  9:17   ` Pavel Modilaynen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66bc78ec83c940cd92932221a0c5c387@XBOX07.axis.com \
    --to=pavel.modilaynen@axis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox