From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB5F5ECAAD3 for ; Fri, 9 Sep 2022 07:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiIIHZV (ORCPT ); Fri, 9 Sep 2022 03:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229905AbiIIHZU (ORCPT ); Fri, 9 Sep 2022 03:25:20 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 566FB52835 for ; Fri, 9 Sep 2022 00:25:19 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id y29so791443ljq.7 for ; Fri, 09 Sep 2022 00:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=rttukWzjV+xvcl0ZdZLEMjvbrPV71XhE0mBEoNsIC0c=; b=Jxi/U+JbUv3v+EznlTNHFlFyGSGuivl713KuaNpo0EYtSonAZkVxGMDug+GbhlR8uc snrfxroNbjYlhnESeju+kc6rjCo+Yog10pZs6pyzXdiWnYo0AVK0unUR1B1UKheb5aRo qNfMmLglHF+PYeMYwodLsLirOEOYRnHWnnYj9kj959eoG3RFklnldruNtJ1T4bfOauPg dvrCrP2WUd6D2aHWgXHFA4ZLWnbe8rC2+mNfL6PzJ4zo0gPdp1JMWDXiXiin3IBcLWKy I5emIXWiaiMjFsF5IOrQkBYxzD4cPMjbwY/DlWwbfTtYg8dzA8zT6N5ISOBYHiJ0YxDl OmYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=rttukWzjV+xvcl0ZdZLEMjvbrPV71XhE0mBEoNsIC0c=; b=bf4hkSD7QhuaQPPC/e6/7CZ8MxX0lzn9M/08XQxGxdx+ENBHOLl4csCeYJnlrL0uuD dt9QJ1/DJOSTTXshWDXifIVFi4Pz3kRkH65hZb+FfrtL1PjewGPWpgYiFq0oC6GvFgPR 2pHfnGohVoMtFNupFsBB7XMhpTlOhx5TFOR84Og5tT4KSXzmm3mQUnFUo3jS2qMndM/+ mijL9qLqlYSZ2yYBMBcH7sDWxbXLXfqnAxXzkPUa2BdrFRclhjKHpgziSlreDunfxPea HScCKhDXKpofG8Qk9b6tTJIAk26MMv61sqUD2DxIy/7CJuTSX8XGsmR3D+jR/xOxQovI uyEA== X-Gm-Message-State: ACgBeo0CRm2WPci4bCwoFHMkgkyeeXOm53gHqACC4weVOzRzV0m1cvWn MnDbdKVglfjqocFPz21SFfaqvQ== X-Google-Smtp-Source: AA6agR487qrszdElZPRRzQQW9lkjNAr16pE+IjQUMK7QInOwDo6bp/ebol2FUs+Rq7JZuSI89hhdBw== X-Received: by 2002:a2e:bd03:0:b0:261:8b4d:7c5c with SMTP id n3-20020a2ebd03000000b002618b4d7c5cmr3798042ljq.194.1662708317694; Fri, 09 Sep 2022 00:25:17 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id h14-20020ac25d6e000000b00496d254bbd9sm150794lft.271.2022.09.09.00.25.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 00:25:17 -0700 (PDT) Message-ID: <66cf260e-b8b2-b3d1-7e8e-d1cfd99989b8@linaro.org> Date: Fri, 9 Sep 2022 09:25:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] dt-bindings: sound: ts3a227e: add control of debounce times Content-Language: en-US To: Astrid Rost , Mark Brown Cc: Astrid Rost , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , kernel@axis.com, alsa-devel-mejlinglistan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220907135827.16209-1-astrid.rost@axis.com> <2b81d814-f47a-e548-83dc-b1e38857e8ce@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/09/2022 09:16, Astrid Rost wrote: > Hello, > > > Use standard property units "-ms". > > I made it in exactly the same way as it is done for the "ti,micbias:". > > - ti,micbias: Intended MICBIAS voltage (datasheet section 9.6.7). > Select 0/1/2/3/4/5/6/7 to specify MICBIAS voltage > 2.1V/2.2V/2.3V/2.4V/2.5V/2.6V/2.7V/2.8V > Default value is "1" (2.2V). That's not correct way. Logical units should be encoded in logical units, e.g. microvolt. This makes the binding re-usable, extendable (imagine new device from the family where these values map to something else!) and also the easiest to read. > ?> Anyway new properties cannot be accepted. This has to be converted to DT > ?> schema (YAML). > > > Doing a whole binding conversion feels like a bit of a steep requirement > > when people are just adding a simple property, it's a lot of stop energy > > to figure out the tooling, do the conversion and deal with all the > > bikeshedding that the tools don't catch. It's definitely nice if people > > want to look at that, for more complex binding changes it gets more > > reasonable but for trivial properties it's disproportionate. > > Thanks, I am not really sure how yaml works. But I can have a look. Documentation/devicetree/bindings/writing-schema.rst (and example-schema in the same place) Best regards, Krzysztof