From: Markus Elfring <Markus.Elfring@web.de>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver
Date: Fri, 28 Mar 2025 14:19:39 +0100 [thread overview]
Message-ID: <66d344b9-5cc6-4060-86ff-8100a00de477@web.de> (raw)
In-Reply-To: <20250326141641.3471906-3-quic_msavaliy@quicinc.com>
…
> +++ b/drivers/i3c/master/qcom-i3c-master.c
> @@ -0,0 +1,1107 @@
…
> +static void geni_i3c_abort_xfer(struct geni_i3c_dev *gi3c)
> +{
…
> + spin_lock_irqsave(&gi3c->irq_lock, flags);
> + geni_i3c_handle_err(gi3c, GENI_TIMEOUT);
> + geni_se_abort_m_cmd(&gi3c->se);
> + spin_unlock_irqrestore(&gi3c->irq_lock, flags);
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&gi3c->irq_lock);”?
https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/spinlock.h#L572
Regards,
Markus
next prev parent reply other threads:[~2025-03-28 13:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 14:16 [PATCH v2 0/3] Add Qualcomm i3c master controller driver support Mukesh Kumar Savaliya
2025-03-26 14:16 ` [PATCH v2 1/3] dt-bindings: i3c: Add Qualcomm I3C master controller Mukesh Kumar Savaliya
2025-03-26 14:23 ` Krzysztof Kozlowski
2025-03-28 14:28 ` Mukesh Kumar Savaliya
2025-03-28 14:33 ` Krzysztof Kozlowski
2025-03-29 9:08 ` Mukesh Kumar Savaliya
2025-03-29 11:06 ` Krzysztof Kozlowski
2025-03-29 14:31 ` Mukesh Kumar Savaliya
2025-03-30 9:42 ` Krzysztof Kozlowski
2025-03-31 6:52 ` Mukesh Kumar Savaliya
2025-03-31 7:06 ` Mukesh Kumar Savaliya
2025-03-26 14:16 ` [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver Mukesh Kumar Savaliya
2025-03-26 14:28 ` Krzysztof Kozlowski
2025-03-28 14:28 ` Mukesh Kumar Savaliya
2025-03-28 14:35 ` Krzysztof Kozlowski
2025-03-26 20:03 ` Frank Li
2025-03-29 9:09 ` Mukesh Kumar Savaliya
2025-03-28 13:19 ` Markus Elfring [this message]
2025-03-28 14:29 ` Mukesh Kumar Savaliya
2025-03-28 19:04 ` [v2 " Markus Elfring
2025-03-29 9:08 ` Mukesh Kumar Savaliya
2025-03-29 9:43 ` Markus Elfring
2025-03-29 10:48 ` Alexandre Belloni
2025-03-29 13:16 ` Markus Elfring
2025-03-29 14:27 ` Mukesh Kumar Savaliya
2025-03-28 13:28 ` [PATCH v2 " Markus Elfring
2025-03-28 14:29 ` Mukesh Kumar Savaliya
2025-03-26 14:16 ` [PATCH v2 3/3] MAINTAINERS: Add maintainer for Qualcomm's I3C driver Mukesh Kumar Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66d344b9-5cc6-4060-86ff-8100a00de477@web.de \
--to=markus.elfring@web.de \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox