Re: [PATCH v2 01/17] dt-bindings: mfd: adp5585: ease on the required properties

["Nuno Sá" <noname.nuno@gmail.com>]

On Mon, 2025-04-21 at 11:56 +0300, Laurent Pinchart wrote:
> Hi Nuno,
> 
> Thank you for the patch.
> 
> On Tue, Apr 15, 2025 at 03:49:17PM +0100, Nuno Sá via B4 Relay wrote:
> > From: Nuno Sá <nuno.sa@analog.com>
> > 
> > It is not mandatory to use all the capabilities of the device. One can
> > very well only use it as a gpio controller without the PWM support. This
> > will be even more evident when support for the matrix keymap is added.
> > Hence drop the requirements for PWM and GPIO.
> 
> This seems to make sense.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> I however expected changes in this series to *not* register MFD cells
> for the devices not enabled in DT. Could you do so in v3, on top of this
> patch ?

Makes sense... In theory, I would go with MFD_CELL_OF() but that would need (I
guess) bindings for all the devices and since PWM and GPIO were not introduced
with that...

Anyways, I'll look into some "mandatory" property for each of the supported
cells and use that as deciding point.

- Nuno Sá

> 
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/adi,adp5585.yaml | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
> > b/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
> > index
> > ee2272f754a339569c793102928ddd13249f8fee..e30e22f964f78519b2ec207e9415e4897d
> > b5c702 100644
> > --- a/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
> > @@ -52,9 +52,6 @@ patternProperties:
> >  required:
> >    - compatible
> >    - reg
> > -  - gpio-controller
> > -  - "#gpio-cells"
> > -  - "#pwm-cells"
> >  
> >  allOf:
> >    - if: