From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "xingu.wu" <xingyu.wu@starfivetech.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] riscv: dts: starfive: jh7110: Add watchdog node
Date: Fri, 2 Dec 2022 11:48:01 +0100 [thread overview]
Message-ID: <66e66749-cc0f-f147-2648-03b52f95cca5@linaro.org> (raw)
In-Reply-To: <20221202093943.149674-4-xingyu.wu@starfivetech.com>
On 02/12/2022 10:39, xingu.wu wrote:
> From: Xingyu Wu <xingyu.wu@starfivetech.com>
>
> This adds the watchdog node for the Starfive JH7110 SoC.
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> ---
> arch/riscv/boot/dts/starfive/jh7110.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index c22e8f1d2640..22f5a37d691e 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -433,5 +433,19 @@ uart5: serial@12020000 {
> reg-shift = <2>;
> status = "disabled";
> };
> +
> + wdog: watchdog@13070000 {
> + compatible = "starfive,jh7110-wdt";
> + reg = <0x0 0x13070000 0x0 0x10000>;
> + interrupts = <68>;
> + clocks = <&syscrg JH7110_SYSCLK_WDT_CORE>,
> + <&syscrg JH7110_SYSCLK_WDT_APB>;
> + clock-names = "core_clk", "apb_clk";
> + resets = <&syscrg JH7110_SYSRST_WDT_APB>,
> + <&syscrg JH7110_SYSRST_WDT_CORE>;
> + reset-names = "rst_apb", "rst_core";
> + timeout-sec = <15>;
> + status = "okay";
Why? okay is by default
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-02 10:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221202093943.149674-1-xingyu.wu@starfivetech.com>
[not found] ` <20221202093943.149674-2-xingyu.wu@starfivetech.com>
2022-12-02 10:46 ` [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive Krzysztof Kozlowski
2022-12-05 3:49 ` Xingyu Wu
2022-12-05 7:30 ` Krzysztof Kozlowski
2022-12-05 8:22 ` Xingyu Wu
[not found] ` <20221202093943.149674-4-xingyu.wu@starfivetech.com>
2022-12-02 10:48 ` Krzysztof Kozlowski [this message]
2022-12-05 8:27 ` [PATCH v1 3/3] riscv: dts: starfive: jh7110: Add watchdog node Xingyu Wu
2022-12-02 11:52 ` [PATCH v1 0/3] Add watchdog driver for StarFive RISC-V SoCs Conor Dooley
[not found] ` <20221202093943.149674-3-xingyu.wu@starfivetech.com>
2022-12-02 15:08 ` [PATCH v1 2/3] drivers: watchdog: Add StarFive Watchdog driver Guenter Roeck
2022-12-05 8:08 ` Xingyu Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66e66749-cc0f-f147-2648-03b52f95cca5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).