From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695D1ECAAD5 for ; Mon, 5 Sep 2022 05:48:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235651AbiIEFsF (ORCPT ); Mon, 5 Sep 2022 01:48:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235313AbiIEFsE (ORCPT ); Mon, 5 Sep 2022 01:48:04 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67DB72D1E6 for ; Sun, 4 Sep 2022 22:48:02 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id l65so7645248pfl.8 for ; Sun, 04 Sep 2022 22:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=/MSOkfzcFDVOwb+RS/ivu6q81kMf5WeXuE6nXo0vYzw=; b=z3ENzGxwfrHKOJ5hIrRFfQWdK9HQXJE5wEl8yca9odjvcVDKEcwYNuUQ3saqPr7miW mF1QpmiMkHGRlte9vIKhtmyw2Sy/HYPnEB5l0DmukbwwXSe65i0rP4myTJdEuHIc8eew eg4Pp3shVhpYya+HcE4TMqeHHN2YkxsnnQyE1vCdRqRHKk/IZPAgjYQk89zKrYpsOgPr T5f+vNtYlsyArA59WQpUBxxxduffw2jFMe5SJht4yBkvdRTU6ERnGc4kb1cY7ltXE7ez FcxSkF4tbvV3aOJoPepuFApEU/5nyYdY6p1jX6nPvao9IYNwByFu4lTIFjDyxueR/5mp p67Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=/MSOkfzcFDVOwb+RS/ivu6q81kMf5WeXuE6nXo0vYzw=; b=Lgu7SyBvnBx1QbrJswgDoV9NVxHEmgfZwA5qcCo8No8niR4srgM9kUueG9TIpkqY2l uhKczBt/LQMVpBbWBMC6N/5iLl+dSa5O34EutKY1KeVHnnIRd+d4hiGhYln9f/pcgFyP Ysj7s20Tt4rV9hVIpWbzlPyGBC9T8r5h/qzfaYo1GS+h4asVHzSV3ocIu0xJewfM9Htd keHIDa4dH4HRKt9uHj9KIOPws/S1h7lWkBuOLx3dnYO4cmoXjFIcpxS+XQD19aVxpzQa 4LQWJrhkJgbb+0PJ3I3OmxH30E9wK1QTku/w4CzZJKR/nVmj0kODirEfLKTO3uhCpvk7 h7Lw== X-Gm-Message-State: ACgBeo1Z89r5gWTSpd9zNhIHUPuQQM6zuSkNqa5KN+P5NDbr5XRNDajV HycqN66nVd4Ewu3kpec+2J7iYw== X-Google-Smtp-Source: AA6agR5F/Rwe8lQfPR84iEIKaj/8EdP4mhMjo5k43tg2ef1dm6TqvKoSPlvY/+MuNlwrFUeNHpymPg== X-Received: by 2002:a05:6a00:1c90:b0:537:e144:4481 with SMTP id y16-20020a056a001c9000b00537e1444481mr43747206pfw.24.1662356881806; Sun, 04 Sep 2022 22:48:01 -0700 (PDT) Received: from ?IPV6:2401:4900:1c60:5362:9d7f:2354:1d0a:78e3? ([2401:4900:1c60:5362:9d7f:2354:1d0a:78e3]) by smtp.gmail.com with ESMTPSA id a6-20020a1709027d8600b00176b63535ccsm636924plm.193.2022.09.04.22.47.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Sep 2022 22:48:01 -0700 (PDT) Message-ID: <66eaf16e-cb7c-a0b4-9ce5-02611308b0e6@linaro.org> Date: Mon, 5 Sep 2022 11:17:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry for pmc8280c_lpg node Content-Language: en-US To: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org, agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Bryan O'Donoghue , Bjorn Andersson References: <20220903084440.1509562-1-bhupesh.sharma@linaro.org> <42790a40-458a-55ff-7e4b-796e72f474ac@kernel.org> From: Bhupesh Sharma In-Reply-To: <42790a40-458a-55ff-7e4b-796e72f474ac@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On 9/5/22 12:52 AM, Krzysztof Kozlowski wrote: > On 03/09/2022 11:44, Bhupesh Sharma wrote: >> Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") >> dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover >> 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same. >> >> While at it, also remove the unused unit address in the node >> label. >> >> Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration") >> Cc: Krzysztof Kozlowski >> Cc: Bryan O'Donoghue >> Cc: Bjorn Andersson >> Signed-off-by: Bhupesh Sharma >> --- >> arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi >> index ae90b97aecb8..2e5cf55afdd5 100644 >> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi >> @@ -60,9 +60,8 @@ pmc8280c_gpios: gpio@8800 { >> #interrupt-cells = <2>; >> }; >> >> - pmc8280c_lpg: lpg@e800 { >> + pmc8280c_lpg: lpg { > > I wonder why I did not see the errors when testing all DTSes for > https://lore.kernel.org/all/20220828084341.112146-9-krzysztof.kozlowski@linaro.org/ I did not see the error while running the 'make dtbs_check' locally, so may be something to improve in 'make dtbs_check' infrastructure there. > Anyway, it cannot be lpg - binding requires "pwm". I think that should be a separate patch. It does not seem related to this change anyways - which fixes eeca7d46217c . I will send a v2 soon. Thanks, Bhupesh