From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v5 2/2] clk: qcom: Add lpass clock controller driver for SDM845
Date: Thu, 4 Oct 2018 17:31:27 +0530 [thread overview]
Message-ID: <66fc65d8-92ec-f32c-6edb-ad4952695395@codeaurora.org> (raw)
In-Reply-To: <153816066933.119890.2976485722156069351@swboyd.mtv.corp.google.com>
On 9/29/2018 12:21 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2018-09-18 03:25:38)
>> @@ -3469,6 +3495,8 @@ enum {
>> [GCC_QSPI_CORE_CLK_SRC] = &gcc_qspi_core_clk_src.clkr,
>> [GCC_QSPI_CORE_CLK] = &gcc_qspi_core_clk.clkr,
>> [GCC_QSPI_CNOC_PERIPH_AHB_CLK] = &gcc_qspi_cnoc_periph_ahb_clk.clkr,
>> + [GCC_LPASS_Q6_AXI_CLK] = NULL,
>> + [GCC_LPASS_SWAY_CLK] = NULL,
>> };
>>
>> static const struct qcom_reset_map gcc_sdm845_resets[] = {
>> @@ -3583,6 +3611,13 @@ static int gcc_sdm845_probe(struct platform_device *pdev)
>> if (ret)
>> return ret;
>>
>> + if (of_property_read_bool(pdev->dev.of_node, "qcom,lpass-protected")) {
>
> Shouldn't this be negated? So that we only add the clks when lpass isn't
> protected?
>
I was of the opinion to add the flag only when LPASS clocks are
required. But I am fine negating it too.
>> + gcc_sdm845_clocks[GCC_LPASS_Q6_AXI_CLK] =
>> + &gcc_lpass_q6_axi_clk.clkr;
>> + gcc_sdm845_clocks[GCC_LPASS_SWAY_CLK] =
>> + &gcc_lpass_sway_clk.clkr;
>> + }
>> +
>> return qcom_cc_really_probe(pdev, &gcc_sdm845_desc, regmap);
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2018-10-04 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 10:25 [PATCH v5 0/2] Add support for LPASS clock controller for SDM845 Taniya Das
2018-09-18 10:25 ` [PATCH v5 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings Taniya Das
2018-09-26 22:47 ` Rob Herring
2018-09-28 18:52 ` Stephen Boyd
2018-09-18 10:25 ` [PATCH v5 2/2] clk: qcom: Add lpass clock controller driver for SDM845 Taniya Das
2018-09-28 18:51 ` Stephen Boyd
2018-10-04 12:01 ` Taniya Das [this message]
2018-10-08 2:45 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66fc65d8-92ec-f32c-6edb-ad4952695395@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).