devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andre Heider <a.heider@gmail.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Tomasz Maciej Nowak <tmn505@gmail.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
Date: Mon, 21 Sep 2020 18:57:46 +0200	[thread overview]
Message-ID: <670c25da-9a3a-9d67-dcc6-bd839235574a@gmail.com> (raw)
In-Reply-To: <20200921165357.yvajlsb6cjojbqqc@pali>

On 21/09/2020 18:53, Pali Rohár wrote:
> On Monday 21 September 2020 18:48:30 Andre Heider wrote:
>> The included armada-372x.dtsi already defines these two aliases.
> 
> Where? I do not see it in that file:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsi

Oh sorry, it's in armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n20

> 
>>
>> Signed-off-by: Andre Heider <a.heider@gmail.com>
>> ---
>>
>> This goes on top of Pali's patch:
>> "arm64: dts: marvell: espressobin: Add ethernet switch aliases"
>>
>> The resulting .dtb files are the same.
>>
>>   arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
>> index 0775c16e0ec8..3169a820558f 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
>> @@ -17,8 +17,6 @@ aliases {
>>   		ethernet1 = &switch0port1;
>>   		ethernet2 = &switch0port2;
>>   		ethernet3 = &switch0port3;
>> -		serial0 = &uart0;
>> -		serial1 = &uart1;
>>   	};
>>   
>>   	chosen {
>> -- 
>> 2.28.0
>>


  reply	other threads:[~2020-09-21 16:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 16:48 [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases Andre Heider
2020-09-21 16:53 ` Pali Rohár
2020-09-21 16:57   ` Andre Heider [this message]
2020-09-21 17:14     ` Pali Rohár
2020-09-22  4:28 ` [PATCH v2] " Andre Heider
2020-09-22  4:31 ` [PATCH v3] " Andre Heider
2020-09-23 15:10 ` [PATCH] " Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=670c25da-9a3a-9d67-dcc6-bd839235574a@gmail.com \
    --to=a.heider@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tmn505@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).