From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Vinod Polimera <quic_vpolimer@quicinc.com>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
linux-kernel@vger.kernel.org, robdclark@gmail.com,
dianders@chromium.org, swboyd@chromium.org,
quic_kalyant@quicinc.com, quic_khsieh@quicinc.com,
quic_vproddut@quicinc.com, quic_bjorande@quicinc.com,
quic_abhinavk@quicinc.com
Subject: Re: [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr
Date: Tue, 31 Jan 2023 14:48:52 +0200 [thread overview]
Message-ID: <670d0a87-a932-6f33-b363-5499dc7ff29f@linaro.org> (raw)
In-Reply-To: <1675091494-13988-10-git-send-email-quic_vpolimer@quicinc.com>
On 30/01/2023 17:11, Vinod Polimera wrote:
> From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
>
> Updated frames get queued if self_refresh_aware is set when the
> sink is in psr. To support bridge enable and avoid queuing of update
> frames, reset the self_refresh_aware state after entering psr.
>
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
> Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
> ---
> drivers/gpu/drm/msm/dp/dp_drm.c | 25 ++++++++++++++++++++++++-
> 1 file changed, 24 insertions(+), 1 deletion(-)
As I stated in v11's discussion, I do not like the way this change plays
with the self_refresh_aware. Please find another way to work around the
timing issue (let's probably continue the discussion back in v11).
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-31 12:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 15:11 [PATCH v12 00/14] Add PSR support for eDP Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 01/14] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 02/14] drm/msm/disp/dpu: get timing engine status from intf status register Vinod Polimera
2023-01-31 12:45 ` Dmitry Baryshkov
2023-01-30 15:11 ` [PATCH v12 03/14] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 04/14] drm/msm/disp/dpu: reset the datapath after timing engine disable Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 05/14] drm: add helper functions to retrieve old and new crtc Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 06/14] drm/msm/dp: use atomic callbacks for DP bridge ops Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 07/14] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 08/14] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr Vinod Polimera
2023-01-31 12:48 ` Dmitry Baryshkov [this message]
2023-02-07 14:28 ` Vinod Polimera
2023-02-07 15:24 ` Dmitry Baryshkov
2023-01-30 15:11 ` [PATCH v12 10/14] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 11/14] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 12/14] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera
2023-01-30 15:11 ` [PATCH v12 13/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera
2023-01-31 12:58 ` Dmitry Baryshkov
2023-02-07 14:26 ` Vinod Polimera
2023-02-07 15:25 ` Dmitry Baryshkov
2023-02-08 21:57 ` Dmitry Baryshkov
2023-01-30 15:11 ` [PATCH v12 14/14] drm/msm/disp/dpu: update dpu_enc crtc state on crtc enable/disable during self refresh Vinod Polimera
2023-01-31 12:45 ` [PATCH v12 00/14] Add PSR support for eDP Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=670d0a87-a932-6f33-b363-5499dc7ff29f@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robdclark@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).