From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902C3C761A6 for ; Mon, 3 Apr 2023 12:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbjDCMRv (ORCPT ); Mon, 3 Apr 2023 08:17:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjDCMRu (ORCPT ); Mon, 3 Apr 2023 08:17:50 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ADFC1025F; Mon, 3 Apr 2023 05:17:48 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 4C03824DFFD; Mon, 3 Apr 2023 20:17:41 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 3 Apr 2023 20:17:41 +0800 Received: from [192.168.125.145] (183.27.97.179) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 3 Apr 2023 20:17:40 +0800 Message-ID: <670fbeaf-334b-b6d7-d48c-0828c5f1d841@starfivetech.com> Date: Mon, 3 Apr 2023 20:17:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v1 1/3] dt-bindings: sound: Add TDM for StarFive JH7110 Content-Language: en-US To: Krzysztof Kozlowski , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing CC: , , , References: <20230329153320.31390-1-walker.chen@starfivetech.com> <20230329153320.31390-2-walker.chen@starfivetech.com> From: Walker Chen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.179] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/3/30 15:39, Krzysztof Kozlowski wrote: > On 29/03/2023 17:33, Walker Chen wrote: >> Add bindings to describe the TDM driver for the StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen >> --- >> .../bindings/sound/starfive,jh7110-tdm.yaml | 95 +++++++++++++++++++ >> 1 file changed, 95 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml >> new file mode 100644 >> index 000000000000..d65b9ed781ef >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml >> @@ -0,0 +1,95 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-tdm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 TDM Controller >> + >> +description: | >> + The TDM Controller is a Time Division Multiplexed audio interface >> + integrated in StarFive JH7110 SoC, allowing up to 8 channels of >> + audio over a serial interface. The TDM controller can operate both >> + in master and slave mode. >> + >> +maintainers: >> + - Walker Chen >> + > > Missing allOf: with $ref to dai-common. Indeed missing allOf, thank you for kind reminding. > >> +properties: >> + compatible: >> + enum: >> + - starfive,jh7110-tdm >> + >> + reg: >> + maxItems: 1 > > (...) > >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - dmas >> + - dma-names >> + - "#sound-dai-cells" >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + tdm: tdm@10090000 { > > Drop tdm label, not used. Ok, will drop it. Best regards, Walker