* [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support
@ 2019-12-28 15:05 James Tai
2019-12-28 15:05 ` [PATCH v2 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: James Tai @ 2019-12-28 15:05 UTC (permalink / raw)
To: linux-realtek-soc
Cc: linux-arm-kernel, Robin Murphy, Lorenzo Pieralisi, linux-kernel,
robh+dt, mark.rutland, devicetree, Andreas Färber
Hi Andreas,
This series adds Device Trees for the Realtek RTD1319 SoC and Realtek's
PymParticle EVB.
The v2 is based on my RTD1619 series and Andreas' RTD1395, syscon series.
v1 -> v2:
* Reserve the boot ROM address
* Reserve boot loader address
* Reserve audio/video FW address
* Reserve RPC and ring budffer address
* Reserve TEE address
* Support 1 GiB RAM by default
* Reduce rbus range to 2 MiB
* Apply the syscon for ISO,MISC,CRT,SB2,SCPU_WRAPPER
* Adjust compatible strings order in document
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Andreas Färber <afaerber@suse.de>
James Tai (2):
dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle
EVB
arm64: dts: realtek: Add RTD1319 SoC and Realtek PymParticle EVB
.../devicetree/bindings/arm/realtek.yaml | 6 +
arch/arm64/boot/dts/realtek/Makefile | 2 +
.../boot/dts/realtek/rtd1319-pymparticle.dts | 43 ++++
arch/arm64/boot/dts/realtek/rtd1319.dtsi | 12 +
arch/arm64/boot/dts/realtek/rtd13xx.dtsi | 212 ++++++++++++++++++
5 files changed, 275 insertions(+)
create mode 100644 arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts
create mode 100644 arch/arm64/boot/dts/realtek/rtd1319.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd13xx.dtsi
--
2.24.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB 2019-12-28 15:05 [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support James Tai @ 2019-12-28 15:05 ` James Tai 2020-01-04 21:07 ` Rob Herring 2019-12-28 15:05 ` [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC " James Tai 2019-12-29 2:48 ` [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support Andreas Färber 2 siblings, 1 reply; 9+ messages in thread From: James Tai @ 2019-12-28 15:05 UTC (permalink / raw) To: linux-realtek-soc Cc: linux-arm-kernel, Robin Murphy, Lorenzo Pieralisi, linux-kernel, robh+dt, mark.rutland, devicetree Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle EVB. Signed-off-by: James Tai <james.tai@realtek.com> --- Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml index e11616883736..cc46d1e27ecc 100644 --- a/Documentation/devicetree/bindings/arm/realtek.yaml +++ b/Documentation/devicetree/bindings/arm/realtek.yaml @@ -43,6 +43,12 @@ properties: - synology,ds418 # Synology DiskStation DS418 - const: realtek,rtd1296 + # RTD1319 SoC based boards + - items: + - enum: + - realtek,pymparticle # Realtek PymParticle EVB + - const: realtek,rtd1319 + # RTD1395 SoC based boards - items: - enum: -- 2.24.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB 2019-12-28 15:05 ` [PATCH v2 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai @ 2020-01-04 21:07 ` Rob Herring 0 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2020-01-04 21:07 UTC (permalink / raw) To: James Tai Cc: linux-realtek-soc, linux-arm-kernel, Robin Murphy, Lorenzo Pieralisi, linux-kernel, mark.rutland, devicetree On Sat, Dec 28, 2019 at 11:05:52PM +0800, James Tai wrote: > Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle > EVB. > > Signed-off-by: James Tai <james.tai@realtek.com> > --- > Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC and Realtek PymParticle EVB 2019-12-28 15:05 [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support James Tai 2019-12-28 15:05 ` [PATCH v2 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai @ 2019-12-28 15:05 ` James Tai 2019-12-28 18:57 ` Marc Zyngier 2019-12-29 2:48 ` [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support Andreas Färber 2 siblings, 1 reply; 9+ messages in thread From: James Tai @ 2019-12-28 15:05 UTC (permalink / raw) To: linux-realtek-soc Cc: linux-arm-kernel, Robin Murphy, Lorenzo Pieralisi, linux-kernel, robh+dt, mark.rutland, devicetree Add Device Trees for Realtek RTD1319 SoC family, RTD1319 SoC and Realtek PymParticle EVB. Signed-off-by: James Tai <james.tai@realtek.com> --- arch/arm64/boot/dts/realtek/Makefile | 2 + .../boot/dts/realtek/rtd1319-pymparticle.dts | 43 ++++ arch/arm64/boot/dts/realtek/rtd1319.dtsi | 12 + arch/arm64/boot/dts/realtek/rtd13xx.dtsi | 212 ++++++++++++++++++ 4 files changed, 269 insertions(+) create mode 100644 arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1319.dtsi create mode 100644 arch/arm64/boot/dts/realtek/rtd13xx.dtsi diff --git a/arch/arm64/boot/dts/realtek/Makefile b/arch/arm64/boot/dts/realtek/Makefile index ef8d8fcbaa05..c0ae96f324eb 100644 --- a/arch/arm64/boot/dts/realtek/Makefile +++ b/arch/arm64/boot/dts/realtek/Makefile @@ -9,6 +9,8 @@ dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb dtb-$(CONFIG_ARCH_REALTEK) += rtd1296-ds418.dtb +dtb-$(CONFIG_ARCH_REALTEK) += rtd1319-pymparticle.dtb + dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-bpi-m4.dtb dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-lionskin.dtb diff --git a/arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts b/arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts new file mode 100644 index 000000000000..2a36d220fef6 --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts @@ -0,0 +1,43 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Copyright (c) 2019 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include "rtd1319.dtsi" + +/ { + compatible = "realtek,pymparticle", "realtek,rtd1319"; + model = "Realtek PymParticle EVB"; + + memory@2e000 { + device_type = "memory"; + reg = <0x2e000 0x3ffd2000>; /* boot ROM to 1 GiB or 2 GiB */ + }; + + chosen { + stdout-path = "serial0:460800n8"; + }; + + aliases { + serial0 = &uart0; + serial1 = &uart1; + serial2 = &uart2; + }; +}; + +/* debug console (J1) */ +&uart0 { + status = "okay"; +}; + +/* M.2 slot (CON8) */ +&uart1 { + status = "disabled"; +}; + +/* GPIO connector (T1) */ +&uart2 { + status = "disabled"; +}; diff --git a/arch/arm64/boot/dts/realtek/rtd1319.dtsi b/arch/arm64/boot/dts/realtek/rtd1319.dtsi new file mode 100644 index 000000000000..1dcee00009cd --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1319.dtsi @@ -0,0 +1,12 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1319 SoC + * + * Copyright (c) 2019 Realtek Semiconductor Corp. + */ + +#include "rtd13xx.dtsi" + +/ { + compatible = "realtek,rtd1319"; +}; diff --git a/arch/arm64/boot/dts/realtek/rtd13xx.dtsi b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi new file mode 100644 index 000000000000..18d063feaa7e --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi @@ -0,0 +1,212 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD13xx SoC family + * + * Copyright (c) 2019 Realtek Semiconductor Corp. + */ + +/memreserve/ 0x0000000000000000 0x000000000002e000; /* Boot ROM */ +/memreserve/ 0x000000000002e000 0x0000000000100000; /* Boot loader */ +/memreserve/ 0x000000000f400000 0x0000000000500000; /* Video FW */ +/memreserve/ 0x000000000f900000 0x0000000000500000; /* Audio FW */ +/memreserve/ 0x0000000010000000 0x0000000000014000; /* Audio FW RAM */ + +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/irq.h> + +/ { + interrupt-parent = <&gic>; + #address-cells = <1>; + #size-cells = <1>; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + rpc_comm: rpc@3f000 { + reg = <0x3f000 0x1000>; + }; + + rpc_ringbuf: rpc@1ffe000 { + reg = <0x1ffe000 0x4000>; + }; + + tee: tee@10100000 { + reg = <0x10100000 0xf00000>; + no-map; + }; + }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu0: cpu@0 { + device_type = "cpu"; + compatible = "arm,cortex-a55"; + reg = <0x0>; + enable-method = "psci"; + next-level-cache = <&l2>; + }; + + cpu1: cpu@100 { + device_type = "cpu"; + compatible = "arm,cortex-a55"; + reg = <0x100>; + enable-method = "psci"; + next-level-cache = <&l2>; + }; + + cpu2: cpu@200 { + device_type = "cpu"; + compatible = "arm,cortex-a55"; + reg = <0x200>; + enable-method = "psci"; + next-level-cache = <&l2>; + }; + + cpu3: cpu@300 { + device_type = "cpu"; + compatible = "arm,cortex-a55"; + reg = <0x300>; + enable-method = "psci"; + next-level-cache = <&l2>; + }; + + l2: l2-cache { + compatible = "cache"; + }; + }; + + timer { + compatible = "arm,armv8-timer"; + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, + <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, + <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, + <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; + }; + + arm_pmu: pmu { + compatible = "arm,armv8-pmuv3"; + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>; + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; + }; + + psci { + compatible = "arm,psci-1.0"; + method = "smc"; + }; + + osc27M: osc { + compatible = "fixed-clock"; + clock-frequency = <27000000>; + clock-output-names = "osc27M"; + #clock-cells = <0>; + }; + + soc { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x00000000 0x00000000 0x0002e000>, /* boot ROM */ + <0xff100000 0xff100000 0x00200000>, /* GIC */ + <0x98000000 0x98000000 0x00200000>; /* rbus */ + + rbus: bus@98000000 { + compatible = "simple-bus"; + reg = <0x98000000 0x200000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x98000000 0x200000>; + + crt: syscon@0 { + compatible = "syscon", "simple-mfd"; + reg = <0x0 0x1000>; + reg-io-width = <4>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x1000>; + }; + + iso: syscon@7000 { + compatible = "syscon", "simple-mfd"; + reg = <0x7000 0x1000>; + reg-io-width = <4>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x7000 0x1000>; + }; + + sb2: syscon@1a000 { + compatible = "syscon", "simple-mfd"; + reg = <0x1a000 0x1000>; + reg-io-width = <4>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1a000 0x1000>; + }; + + misc: syscon@1b000 { + compatible = "syscon", "simple-mfd"; + reg = <0x1b000 0x1000>; + reg-io-width = <4>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1b000 0x1000>; + }; + + scpu_wrapper: syscon@1d000 { + compatible = "syscon", "simple-mfd"; + reg = <0x1d000 0x1000>; + reg-io-width = <4>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1d000 0x1000>; + }; + }; + + gic: interrupt-controller@ff100000 { + compatible = "arm,gic-v3"; + reg = <0xff100000 0x10000>, + <0xff140000 0xc0000>; + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; + interrupt-controller; + #interrupt-cells = <3>; + }; + }; +}; + +&iso { + uart0: serial0@800 { + compatible = "snps,dw-apb-uart"; + reg = <0x800 0x400>; + reg-shift = <2>; + reg-io-width = <4>; + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <432000000>; + status = "disabled"; + }; +}; + +&misc { + uart1: serial1@200 { + compatible = "snps,dw-apb-uart"; + reg = <0x200 0x400>; + reg-shift = <2>; + reg-io-width = <4>; + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <432000000>; + status = "disabled"; + }; + + uart2: serial2@400 { + compatible = "snps,dw-apb-uart"; + reg = <0x400 0x400>; + reg-shift = <2>; + reg-io-width = <4>; + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <432000000>; + status = "disabled"; + }; +}; -- 2.24.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC and Realtek PymParticle EVB 2019-12-28 15:05 ` [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC " James Tai @ 2019-12-28 18:57 ` Marc Zyngier 2019-12-29 7:46 ` James Tai 0 siblings, 1 reply; 9+ messages in thread From: Marc Zyngier @ 2019-12-28 18:57 UTC (permalink / raw) To: James Tai Cc: linux-realtek-soc, mark.rutland, devicetree, Lorenzo Pieralisi, linux-kernel, robh+dt, Robin Murphy, linux-arm-kernel On 2019-12-28 15:05, James Tai wrote: > Add Device Trees for Realtek RTD1319 SoC family, RTD1319 SoC and > Realtek PymParticle EVB. > > Signed-off-by: James Tai <james.tai@realtek.com> > --- > arch/arm64/boot/dts/realtek/Makefile | 2 + > .../boot/dts/realtek/rtd1319-pymparticle.dts | 43 ++++ > arch/arm64/boot/dts/realtek/rtd1319.dtsi | 12 + > arch/arm64/boot/dts/realtek/rtd13xx.dtsi | 212 ++++++++++++++++++ > 4 files changed, 269 insertions(+) > create mode 100644 arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts > create mode 100644 arch/arm64/boot/dts/realtek/rtd1319.dtsi > create mode 100644 arch/arm64/boot/dts/realtek/rtd13xx.dtsi > > diff --git a/arch/arm64/boot/dts/realtek/Makefile > b/arch/arm64/boot/dts/realtek/Makefile > index ef8d8fcbaa05..c0ae96f324eb 100644 > --- a/arch/arm64/boot/dts/realtek/Makefile > +++ b/arch/arm64/boot/dts/realtek/Makefile > @@ -9,6 +9,8 @@ dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb > > dtb-$(CONFIG_ARCH_REALTEK) += rtd1296-ds418.dtb > > +dtb-$(CONFIG_ARCH_REALTEK) += rtd1319-pymparticle.dtb > + > dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-bpi-m4.dtb > dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-lionskin.dtb > > diff --git a/arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts > b/arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts > new file mode 100644 > index 000000000000..2a36d220fef6 > --- /dev/null > +++ b/arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts > @@ -0,0 +1,43 @@ > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +/* > + * Copyright (c) 2019 Realtek Semiconductor Corp. > + */ > + > +/dts-v1/; > + > +#include "rtd1319.dtsi" > + > +/ { > + compatible = "realtek,pymparticle", "realtek,rtd1319"; > + model = "Realtek PymParticle EVB"; > + > + memory@2e000 { > + device_type = "memory"; > + reg = <0x2e000 0x3ffd2000>; /* boot ROM to 1 GiB or 2 GiB */ > + }; > + > + chosen { > + stdout-path = "serial0:460800n8"; > + }; > + > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; > + serial2 = &uart2; > + }; > +}; > + > +/* debug console (J1) */ > +&uart0 { > + status = "okay"; > +}; > + > +/* M.2 slot (CON8) */ > +&uart1 { > + status = "disabled"; > +}; > + > +/* GPIO connector (T1) */ > +&uart2 { > + status = "disabled"; > +}; > diff --git a/arch/arm64/boot/dts/realtek/rtd1319.dtsi > b/arch/arm64/boot/dts/realtek/rtd1319.dtsi > new file mode 100644 > index 000000000000..1dcee00009cd > --- /dev/null > +++ b/arch/arm64/boot/dts/realtek/rtd1319.dtsi > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +/* > + * Realtek RTD1319 SoC > + * > + * Copyright (c) 2019 Realtek Semiconductor Corp. > + */ > + > +#include "rtd13xx.dtsi" > + > +/ { > + compatible = "realtek,rtd1319"; > +}; > diff --git a/arch/arm64/boot/dts/realtek/rtd13xx.dtsi > b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi > new file mode 100644 > index 000000000000..18d063feaa7e > --- /dev/null > +++ b/arch/arm64/boot/dts/realtek/rtd13xx.dtsi > @@ -0,0 +1,212 @@ > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +/* > + * Realtek RTD13xx SoC family > + * > + * Copyright (c) 2019 Realtek Semiconductor Corp. > + */ > + > +/memreserve/ 0x0000000000000000 0x000000000002e000; /* Boot ROM */ > +/memreserve/ 0x000000000002e000 0x0000000000100000; /* Boot loader */ > +/memreserve/ 0x000000000f400000 0x0000000000500000; /* Video FW */ > +/memreserve/ 0x000000000f900000 0x0000000000500000; /* Audio FW */ > +/memreserve/ 0x0000000010000000 0x0000000000014000; /* Audio FW RAM */ > + > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/interrupt-controller/irq.h> > + > +/ { > + interrupt-parent = <&gic>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + rpc_comm: rpc@3f000 { > + reg = <0x3f000 0x1000>; > + }; > + > + rpc_ringbuf: rpc@1ffe000 { > + reg = <0x1ffe000 0x4000>; > + }; > + > + tee: tee@10100000 { > + reg = <0x10100000 0xf00000>; > + no-map; > + }; > + }; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55"; > + reg = <0x0>; > + enable-method = "psci"; > + next-level-cache = <&l2>; > + }; > + > + cpu1: cpu@100 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55"; > + reg = <0x100>; > + enable-method = "psci"; > + next-level-cache = <&l2>; > + }; > + > + cpu2: cpu@200 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55"; > + reg = <0x200>; > + enable-method = "psci"; > + next-level-cache = <&l2>; > + }; > + > + cpu3: cpu@300 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55"; > + reg = <0x300>; > + enable-method = "psci"; > + next-level-cache = <&l2>; > + }; > + > + l2: l2-cache { > + compatible = "cache"; > + }; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, > + <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, > + <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, > + <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; Nit: At some point, it'd be good to be able to describe the EL2 virtual timer interrupt too. Not specially important, but since these ARMv8.2 CPUs have it... [...] > + gic: interrupt-controller@ff100000 { > + compatible = "arm,gic-v3"; > + reg = <0xff100000 0x10000>, > + <0xff140000 0xc0000>; Are you sure about the size of the GICR region? For 4 CPUs, it should be 0x80000. Here, you have a range for 6 CPUs. Has the GIC been sized for 6 CPUs? Are you missing 2 CPUs in the DT? M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC and Realtek PymParticle EVB 2019-12-28 18:57 ` Marc Zyngier @ 2019-12-29 7:46 ` James Tai 2019-12-29 11:29 ` Marc Zyngier 0 siblings, 1 reply; 9+ messages in thread From: James Tai @ 2019-12-29 7:46 UTC (permalink / raw) To: Marc Zyngier Cc: linux-realtek-soc@lists.infradead.org, mark.rutland@arm.com, devicetree@vger.kernel.org, Lorenzo Pieralisi, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Robin Murphy, linux-arm-kernel@lists.infradead.org Hi Marc, Thanks for review. > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, > > + <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, > > + <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, > > + <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; > > Nit: At some point, it'd be good to be able to describe the EL2 virtual timer > interrupt too. Not specially important, but since these ARMv8.2 CPUs have it... I will add the EL2 virtual timer interrupt to timer node. > > + gic: interrupt-controller@ff100000 { > > + compatible = "arm,gic-v3"; > > + reg = <0xff100000 0x10000>, > > + <0xff140000 0xc0000>; > > Are you sure about the size of the GICR region? For 4 CPUs, it should be > 0x80000. Here, you have a range for 6 CPUs. The GICR region should be 0x80000 because the RTD1319 SoC have only 4 CPUs. Thank you. Regards, James ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC and Realtek PymParticle EVB 2019-12-29 7:46 ` James Tai @ 2019-12-29 11:29 ` Marc Zyngier 0 siblings, 0 replies; 9+ messages in thread From: Marc Zyngier @ 2019-12-29 11:29 UTC (permalink / raw) To: James Tai Cc: linux-realtek-soc, mark.rutland, devicetree, Lorenzo Pieralisi, linux-kernel, robh+dt, Robin Murphy, linux-arm-kernel On 2019-12-29 07:46, James Tai wrote: > Hi Marc, > > Thanks for review. > >> > + timer { >> > + compatible = "arm,armv8-timer"; >> > + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, >> > + <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, >> > + <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, >> > + <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>; >> >> Nit: At some point, it'd be good to be able to describe the EL2 >> virtual timer >> interrupt too. Not specially important, but since these ARMv8.2 CPUs >> have it... > > I will add the EL2 virtual timer interrupt to timer node. If you do this, please update the binding first, as this interrupt is not described there yet. > >> > + gic: interrupt-controller@ff100000 { >> > + compatible = "arm,gic-v3"; >> > + reg = <0xff100000 0x10000>, >> > + <0xff140000 0xc0000>; >> >> Are you sure about the size of the GICR region? For 4 CPUs, it should >> be >> 0x80000. Here, you have a range for 6 CPUs. > > The GICR region should be 0x80000 because the RTD1319 SoC have only 4 > CPUs. OK. Please verify that this is actually the case, and that the last redistributor (at offset 0x60000) has GICR_TYPER.Last set. I have recently seen GICs configured for a larger number of CPUs where some of them were disabled in HW, and the DT was wrongly describing some of the redistributors only, leading to SW crashes. Thanks, M. -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support 2019-12-28 15:05 [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support James Tai 2019-12-28 15:05 ` [PATCH v2 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai 2019-12-28 15:05 ` [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC " James Tai @ 2019-12-29 2:48 ` Andreas Färber 2019-12-29 7:57 ` James Tai 2 siblings, 1 reply; 9+ messages in thread From: Andreas Färber @ 2019-12-29 2:48 UTC (permalink / raw) To: James Tai Cc: linux-realtek-soc, linux-arm-kernel, Robin Murphy, Lorenzo Pieralisi, linux-kernel, robh+dt, mark.rutland, devicetree Hi James, Am 28.12.19 um 16:05 schrieb James Tai: > Cc: Andreas Färber <afaerber@suse.de> This time you CC'ed me only on the cover letter, so that I didn't get notified of, e.g., Marc's review comments. I wonder why: realtek.yaml is in MAINTAINERS, and so is dts/realtek/, so get_maintainers.pl should've picked me up, even if you forgot to explicitly CC me? Please check what went wrong there and make sure it doesn't happen again for the next submission. Thanks, Andreas > .../devicetree/bindings/arm/realtek.yaml | 6 + > arch/arm64/boot/dts/realtek/Makefile | 2 + > .../boot/dts/realtek/rtd1319-pymparticle.dts | 43 ++++ > arch/arm64/boot/dts/realtek/rtd1319.dtsi | 12 + > arch/arm64/boot/dts/realtek/rtd13xx.dtsi | 212 ++++++++++++++++++ > 5 files changed, 275 insertions(+) > create mode 100644 arch/arm64/boot/dts/realtek/rtd1319-pymparticle.dts > create mode 100644 arch/arm64/boot/dts/realtek/rtd1319.dtsi > create mode 100644 arch/arm64/boot/dts/realtek/rtd13xx.dtsi -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support 2019-12-29 2:48 ` [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support Andreas Färber @ 2019-12-29 7:57 ` James Tai 0 siblings, 0 replies; 9+ messages in thread From: James Tai @ 2019-12-29 7:57 UTC (permalink / raw) To: Andreas Färber Cc: linux-realtek-soc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Robin Murphy, Lorenzo Pieralisi, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org Hi Andreas, > This time you CC'ed me only on the cover letter, so that I didn't get notified of, > e.g., Marc's review comments. I wonder why: realtek.yaml is in MAINTAINERS, > and so is dts/realtek/, so get_maintainers.pl should've picked me up, even if > you forgot to explicitly CC me? Please check what went wrong there and make > sure it doesn't happen again for the next submission. > I will check it and make sure it doesn't happen again for the next submission. Thanks. Regards, James ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-04 21:07 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-12-28 15:05 [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support James Tai 2019-12-28 15:05 ` [PATCH v2 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB James Tai 2020-01-04 21:07 ` Rob Herring 2019-12-28 15:05 ` [PATCH v2 2/2] arm64: dts: realtek: Add RTD1319 SoC " James Tai 2019-12-28 18:57 ` Marc Zyngier 2019-12-29 7:46 ` James Tai 2019-12-29 11:29 ` Marc Zyngier 2019-12-29 2:48 ` [PATCH v2 0/2] Initial RTD1319 SoC and Realtek PymParticle EVB support Andreas Färber 2019-12-29 7:57 ` James Tai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).