From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E206D1AAC4; Sat, 7 Dec 2024 17:45:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733593540; cv=none; b=geCQtZ1z+ZoaIBOk3IozjA5eHteNx6QX8kH13rftv6948fkF4gEParyu4QpzWL8Q+OoonbP2M6/czRdy/0tCRp+J0ICRqVxiKzLq4+lShpf1/pYRRifYg6Sn7oYDR85X6M0vCSJ3wD30eboZ51fEZbI94ajgVue01r5+pqZvXM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733593540; c=relaxed/simple; bh=6ACLIbj0m2p/gYfZg8qQpPjIeXEXhY3p5smFYzkPywY=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P2VjHyE9PwdkqeJjpk7cRHuxct/NLPUAM3qyvVEJmdNz4v1+vE1lpQq29MCwnTSUBBIpTa5JAcX/5iY5oHBtTW8aRxu5cQMc/qn7Nh7J1nnIUfVep3XvpMlJh9rdJxhcGCpRyPDZGrcSToL9RoO3MR6zqcsMGX07fBXgjv0KnEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gJifVKBQ; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gJifVKBQ" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-29f7c3bcf45so1027011fac.1; Sat, 07 Dec 2024 09:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733593538; x=1734198338; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=b7u+31u3YeBNl7LbEDjuCwStYnmV/fCXULkXKvpnwA8=; b=gJifVKBQ3F4f+lPbSVToNZkWAdhflI/0t/9G8PqQ/qkvojOHfAxsFVf1hT+6TdKdEY JNFShCXJjD9Xkow9pLbJm/qB0cvoN1xXgy1QQ6ot2F6jRCWKivHCZPxnvtaQ/knnZyBI sHUFjuksNI8dpFsPK+4hkh8p6ljK+UD311dmIj8DGsub3RFA+xqTd1BNPxuTY02qZXno 4yXz+oo4K8VMapjHg5Y9GvYSF4ROlD/JgLsHCAffshLFo5kN3vbzcmL/GEk/dufUm7v5 AqGcDo68oLoUDi35AGv2CGQmq7Q3bU08aaikAHr80/MhZhPMnW+VPLgH3jQTRnctQv5d +VGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733593538; x=1734198338; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b7u+31u3YeBNl7LbEDjuCwStYnmV/fCXULkXKvpnwA8=; b=cYCH85R2by/CxNJaHb9ZRSAgZ/36IjJilm2JoFJFS1tSe6+1uQHEeq17ZMEsJfdjzb nBh8AYuYIAPDLZ+Rg2K5Bjd554rQ4/e9gARZK9q9l07Sj4gydFDV/cOezKytFwQ1b+1V jx28bJrwfqeOhHPWxmVIU64N7PaiCeBWQ0KqmnBEAesQED8ubK1rNjmNV3fhglXp8t/c zjnjUGiSPW0D6+wwSAmMChRjYijkzj8llMtIU+pKYoNMc06aOMCCE5CfJj8UPWdDjLDP DNceMejYaTnIyfLMytqpgkCOWaNcD1h0V7QU3HsbOu+Kjb7yhnpl84mopPKtdLW0FI6I RxTw== X-Forwarded-Encrypted: i=1; AJvYcCWCp/mmr4FC+hppync0CMnIpZFC4tlpKXQXkWA7tBLtIrnmKFNzJuI47AYdNk4m6bV/8sUseHX8bpJrl4cT@vger.kernel.org, AJvYcCXm8pdpvBi7GUhtzo7c9ieZ/lvzmLaE8TLFM9eU3M7a1RL6BZA1CGrX5N1geKbJAYbHVpK2fnYiBQW9@vger.kernel.org X-Gm-Message-State: AOJu0Yy/BIH0AF4/tT65Ef5iCs5fKG7f6HoqNL8G4XAr9T3vfkPFwWR5 G9+p8NDbsYooMLBpPEb1NOg9EPsmlX4cUoYauR9Ek2mr8XhJ2gBF X-Gm-Gg: ASbGncsoloQnxS7EZyFkxMtdFTJs+Vmb3Z0kW9vhSxQrgIHQPGyrpHiXAT6/Ox0NxLl H9ekrPwOwbYEMgk+PSky0VG6aaKFToDdZyA6Q6Jxy9XAfXY5dI19J8IPw44oM0tjJD8ZWCP2FMX 5wbYHwJmCtP+PRNgd+vzJqek1dDu5Zt97lEveQGFm8Sxg1JqE4J4+O9e5HQcoTeB0PxeSLcCH38 cjq2MAc4R2NZcJ5MqeMUHlUxGTa6BG2ZmFD X-Google-Smtp-Source: AGHT+IEEIIxwno7M9jy0PuuqAGrIdi1MzgT6bGTTwtmEeVXH12xtChFy+ymdFQtAfHwdBrm9C4sFsg== X-Received: by 2002:a05:6871:a6aa:b0:297:2719:deb6 with SMTP id 586e51a60fabf-29f7319b029mr3489071fac.1.1733593537886; Sat, 07 Dec 2024 09:45:37 -0800 (PST) Received: from neuromancer. ([2600:1700:fb0:1bcf::54]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-29f5694a265sm1545266fac.34.2024.12.07.09.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Dec 2024 09:45:37 -0800 (PST) Message-ID: <675489c1.050a0220.8d73f.6e90@mx.google.com> X-Google-Original-Message-ID: Date: Sat, 7 Dec 2024 11:45:36 -0600 From: Chris Morgan To: Andre Przywara Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Botka , Chris Morgan Subject: Re: [PATCH v2 3/5] mfd: axp20x: Allow multiple regulators References: <20241007001408.27249-1-andre.przywara@arm.com> <20241007001408.27249-4-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241007001408.27249-4-andre.przywara@arm.com> On Mon, Oct 07, 2024 at 01:14:06AM +0100, Andre Przywara wrote: > At the moment trying to register a second AXP chip makes the probe fail, > as some sysfs registration fails due to a duplicate name: > > ... > [ 3.688215] axp20x-i2c 0-0035: AXP20X driver loaded > [ 3.695610] axp20x-i2c 0-0036: AXP20x variant AXP323 found > [ 3.706151] sysfs: cannot create duplicate filename '/bus/platform/devices/axp20x-regulator' > [ 3.714718] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0-rc1-00026-g50bf2e2c079d-dirty #192 > [ 3.724020] Hardware name: Avaota A1 (DT) > [ 3.728029] Call trace: > [ 3.730477] dump_backtrace+0x94/0xec > [ 3.734146] show_stack+0x18/0x24 > [ 3.737462] dump_stack_lvl+0x80/0xf4 > [ 3.741128] dump_stack+0x18/0x24 > [ 3.744444] sysfs_warn_dup+0x64/0x80 > [ 3.748109] sysfs_do_create_link_sd+0xf0/0xf8 > [ 3.752553] sysfs_create_link+0x20/0x40 > [ 3.756476] bus_add_device+0x64/0x104 > [ 3.760229] device_add+0x310/0x760 > [ 3.763717] platform_device_add+0x10c/0x238 > [ 3.767990] mfd_add_device+0x4ec/0x5c8 > [ 3.771829] mfd_add_devices+0x88/0x11c > [ 3.775666] axp20x_device_probe+0x70/0x184 > [ 3.779851] axp20x_i2c_probe+0x9c/0xd8 > ... > > This is because we use PLATFORM_DEVID_NONE for the mfd_add_devices() > call, which would number the child devices in the same 0-based way, even > for the second (or any other) instance. > > Use PLATFORM_DEVID_AUTO instead, which automatically assigns > non-conflicting device numbers. > > Signed-off-by: Andre Przywara > Reviewed-by: Chen-Yu Tsai > --- > drivers/mfd/axp20x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 5ceea359289f4..bc08ae4332604 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -1419,7 +1419,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x) > } > } > > - ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells, > + ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_AUTO, axp20x->cells, > axp20x->nr_cells, NULL, 0, NULL); > > if (ret) { > -- > 2.46.2 > Using git bisect, I found that this patch breaks the CONFIG_AXP20X_ADC option which is used by some of the battery and charger drivers for the axp20x PMIC series. My current assumption is that the devm_iio_channel_get() call made by these drivers worked correctly previously when the PLATFORM_DEVID_NONE, but now it's not working anymore. I'm still testing possible solutions for that problem. Thank you, Chris