From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Mehdi Djait <mehdi.djait@bootlin.com>,
mchehab@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl,
laurent.pinchart@ideasonboard.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
alexandre.belloni@bootlin.com, maxime.chevallier@bootlin.com,
paul.kocialkowski@bootlin.com,
Mehdi Djait <mehdi.djait@bootlin.com>
Subject: Re: [PATCH v8 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder
Date: Mon, 20 Nov 2023 06:32:25 -0500 [thread overview]
Message-ID: <675bc18e-4a9c-4e3c-8ae5-bdb8a2d2cfbe@suswa.mountain> (raw)
In-Reply-To: <93354996c95926970684498f08061b60a52bb84c.1699449537.git.mehdi.djait@bootlin.com>
Hi Mehdi,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mehdi-Djait/dt-bindings-vendor-prefixes-Add-techwell-vendor-prefix/20231109-042139
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/93354996c95926970684498f08061b60a52bb84c.1699449537.git.mehdi.djait%40bootlin.com
patch subject: [PATCH v8 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder
config: i386-randconfig-141-20231111 (https://download.01.org/0day-ci/archive/20231111/202311110759.PJpNGc2N-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231111/202311110759.PJpNGc2N-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311110759.PJpNGc2N-lkp@intel.com/
smatch warnings:
drivers/media/i2c/tw9900.c:398 tw9900_s_std() error: uninitialized symbol 'mode'.
vim +/mode +398 drivers/media/i2c/tw9900.c
4fa88742527a9a Mehdi Djait 2023-11-08 384 static int tw9900_s_std(struct v4l2_subdev *sd, v4l2_std_id std)
4fa88742527a9a Mehdi Djait 2023-11-08 385 {
4fa88742527a9a Mehdi Djait 2023-11-08 386 struct tw9900 *tw9900 = to_tw9900(sd);
4fa88742527a9a Mehdi Djait 2023-11-08 387 const struct tw9900_mode *mode;
This should be "const struct tw9900_mode *mode = NULL;"
4fa88742527a9a Mehdi Djait 2023-11-08 388 int i, ret = 0;
4fa88742527a9a Mehdi Djait 2023-11-08 389
4fa88742527a9a Mehdi Djait 2023-11-08 390 if (!(std & (V4L2_STD_NTSC | V4L2_STD_PAL)))
4fa88742527a9a Mehdi Djait 2023-11-08 391 return -EINVAL;
4fa88742527a9a Mehdi Djait 2023-11-08 392
4fa88742527a9a Mehdi Djait 2023-11-08 393 mutex_lock(&tw9900->mutex);
4fa88742527a9a Mehdi Djait 2023-11-08 394
4fa88742527a9a Mehdi Djait 2023-11-08 395 for (i = 0; i < ARRAY_SIZE(supported_modes); i++)
4fa88742527a9a Mehdi Djait 2023-11-08 396 if (supported_modes[i].std & std)
4fa88742527a9a Mehdi Djait 2023-11-08 397 mode = &supported_modes[i];
4fa88742527a9a Mehdi Djait 2023-11-08 @398 if (!mode) {
^^^^
Either valid or uninitialized.
4fa88742527a9a Mehdi Djait 2023-11-08 399 ret = -EINVAL;
4fa88742527a9a Mehdi Djait 2023-11-08 400 goto out_unlock;
4fa88742527a9a Mehdi Djait 2023-11-08 401 }
4fa88742527a9a Mehdi Djait 2023-11-08 402
4fa88742527a9a Mehdi Djait 2023-11-08 403 tw9900->cur_mode = mode;
4fa88742527a9a Mehdi Djait 2023-11-08 404
4fa88742527a9a Mehdi Djait 2023-11-08 405 out_unlock:
4fa88742527a9a Mehdi Djait 2023-11-08 406 mutex_unlock(&tw9900->mutex);
4fa88742527a9a Mehdi Djait 2023-11-08 407
4fa88742527a9a Mehdi Djait 2023-11-08 408 return ret;
4fa88742527a9a Mehdi Djait 2023-11-08 409 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-11-20 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 13:27 [PATCH v8 0/3] media: i2c: Introduce driver for the TW9900 video decoder Mehdi Djait
2023-11-08 13:27 ` [PATCH v8 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix Mehdi Djait
2023-11-08 13:27 ` [PATCH v8 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900 Mehdi Djait
2023-11-08 19:00 ` Rob Herring
2023-11-08 13:27 ` [PATCH v8 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder Mehdi Djait
2023-11-09 7:06 ` kernel test robot
2023-11-16 15:47 ` Paul Kocialkowski
2023-11-20 11:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675bc18e-4a9c-4e3c-8ae5-bdb8a2d2cfbe@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@bootlin.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox