From: Marek Vasut <marex@denx.de>
To: Frieder Schrempf <frieder.schrempf@kontron.de>,
Claudius Heine <ch@denx.de>, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: imx: imx8mm: fix pad offset of SD1_DATA0 pin
Date: Thu, 11 Feb 2021 12:20:48 +0100 [thread overview]
Message-ID: <675ce5b7-1854-e168-55e4-1db90adce0a1@denx.de> (raw)
In-Reply-To: <03ac353d-e7a1-5235-a787-21014d0c7607@kontron.de>
On 2/11/21 11:17 AM, Frieder Schrempf wrote:
> On 11.02.21 10:54, Claudius Heine wrote:
>> There is a 0 missing in the pad register offset. This patch adds it.
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>
> I think this should rather be prefixed by "arm64: dts: imx8mm:" as this
> is no change in the pinctrl driver, but only in the devicetree.
>
> And I guess this deserves a "Fixes" and "Cc: stable" tag, so:
>
> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for
> imx8mm")
> Cc: stable@vger.kernel.org
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Indeed.
But since this isn't the first such fix, I wonder whether it wouldn't be
a good idea to regenerate those pinctrl tables and see whether there are
any other such issues in them. I wonder, is there some sort of register
and bit list in machine-parseable form for the MX8M ?
prev parent reply other threads:[~2021-02-11 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 9:54 [PATCH] pinctrl: imx: imx8mm: fix pad offset of SD1_DATA0 pin Claudius Heine
2021-02-11 10:15 ` Claudius Heine
2021-02-11 10:17 ` Fabio Estevam
2021-02-11 10:17 ` Frieder Schrempf
2021-02-11 11:20 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675ce5b7-1854-e168-55e4-1db90adce0a1@denx.de \
--to=marex@denx.de \
--cc=ch@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox