devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: hisilicon: Remove unused and undocumented "enable-dma" property
@ 2024-11-15 19:34 Rob Herring (Arm)
  2025-01-02 11:26 ` Wei Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-11-15 19:34 UTC (permalink / raw)
  To: Wei Xu, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, devicetree, linux-kernel

Remove "enable-dma" property which is both unused in the kernel and
undocumented. Most likely they are leftovers from downstream.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index a589954c29e2..12f621cedf89 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -728,7 +728,6 @@ spi0: spi@f7106000 {
 			reg = <0x0 0xf7106000 0x0 0x1000>;
 			interrupts = <0 50 4>;
 			bus-id = <0>;
-			enable-dma = <0>;
 			clocks = <&sys_ctrl HI6220_SPI_CLK>, <&sys_ctrl HI6220_SPI_CLK>;
 			clock-names = "sspclk", "apb_pclk";
 			pinctrl-names = "default";
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: hisilicon: Remove unused and undocumented "enable-dma" property
  2024-11-15 19:34 [PATCH] arm64: dts: hisilicon: Remove unused and undocumented "enable-dma" property Rob Herring (Arm)
@ 2025-01-02 11:26 ` Wei Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Wei Xu @ 2025-01-02 11:26 UTC (permalink / raw)
  To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-kernel, devicetree, linux-kernel, xuwei5

Hi Rob,

On 2024/11/16 3:34, Rob Herring (Arm) wrote:
> Remove "enable-dma" property which is both unused in the kernel and
> undocumented. Most likely they are leftovers from downstream.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index a589954c29e2..12f621cedf89 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -728,7 +728,6 @@ spi0: spi@f7106000 {
>  			reg = <0x0 0xf7106000 0x0 0x1000>;
>  			interrupts = <0 50 4>;
>  			bus-id = <0>;
> -			enable-dma = <0>;
>  			clocks = <&sys_ctrl HI6220_SPI_CLK>, <&sys_ctrl HI6220_SPI_CLK>;
>  			clock-names = "sspclk", "apb_pclk";
>  			pinctrl-names = "default";
> 

Thanks!
Since the "enable-dma" and "bus-id" both are not used by the pl022 driver,
when applying this patch, I have removed the "bus-id" and changed the 
commit message as well.

The detail is as following:
https://github.com/hisilicon/linux-hisi/commit/4a45f8c502a8b8a836c3c932a18d538856097ac7

Best Regards,
Wei

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-02 11:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-15 19:34 [PATCH] arm64: dts: hisilicon: Remove unused and undocumented "enable-dma" property Rob Herring (Arm)
2025-01-02 11:26 ` Wei Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).